Fix default and minimum value for CPU Shares

[marusak]

Minimum value is 2.
Default value is 1024. We still test that if we don't set it up, it is
0, but for that see containers/podman#4822

Fixes #287

[martinpitt]

Admitteldy I don't like hardcoding this default very much, but of course the UI needs to know what to set the value to once you enable CPU shares. But given that "0" means "use the internal default", not literally "zero shares", could we just continue to interpret it that way? I. e. with "0" the setting would just appear disabled?

[marusak]

I don't think that 0 means that. 0 is not defined anywhere what it mean, and seems that podman inspects shows 0 wrongly.
If we don't want 1024, then I would rather suggest not having any value.

[martinpitt]

Right, if it works with null and then just not gets passed, that'd be even better of course -- we leave it as internal podman default then.

[marusak]

Ok, so I dropped the default value.
Forgot to change the commit message, but I'll update that on marging.

[martinpitt]

Thanks! "2" instead of "null" is so that it gets along with the input element, I suppose?

[marusak]

Thanks! "2" instead of "null" is so that it gets along with the input element, I suppose?

Yeah, we could either have no check for minimum value or check for specific value. And it is always the best approach to have native elements doing as much work as possible - rather than we would manually check if the value is >= 2.