Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: data dir backup/restore robustification #1580

Merged
merged 2 commits into from
Feb 27, 2024

Conversation

martinpitt
Copy link
Member

Should help with failures like this and this

These often keep files in /var/lib/containers/ busy and break the
cleanup. They also potentially affect subsequent tests.
This doesn't seem to be necessary any more, podman is happy with an
overmount.

A mount is more efficient and robust to clean up, and avoids `cp -a`
failures.

This reverts commit 2a64c94.
@martinpitt
Copy link
Member Author

Works! I'll push a refined commit message.

@martinpitt martinpitt merged commit ab8108e into cockpit-project:main Feb 27, 2024
34 of 35 checks passed
@martinpitt martinpitt deleted the restore branch February 27, 2024 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
flake unstable test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants