Serialize start and remove event handling #1334
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Factor out the functionality into two helper methods, and use them in testPods as well. That had the same bugs as testLifecycleOperationsUser in commit 4ba8fc1. - The `Pid` field is "0" while the container is not running yet. So don't accept that. - Sleep in the waiting loop to avoid excessive polling.
Don't start pod and container state updates at the same time. They do asynchronous state updates which sometimes step on each other's toes and reverse the real event order. This mitigates the problem with getting podman API call results in the wrong order (containers/podman#19124); that causes containers to sometimes appear in a non-current state.
cockpituous
reviewed
Jul 5, 2023
| // HACK: we don't get a pod event when a container in a pod is removed. | ||
| // https://github.com/containers/podman/issues/15408 | ||
| if (event.Actor.Attributes.podId) | ||
| this.updatePodAfterEvent(event.Actor.Attributes.podId, system); |
There was a problem hiding this comment.
This added line is not executed by any test. Details
jelly
approved these changes
Jul 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't start pod and container state updates at the same time. They do asynchronous state updates which sometimes step on each other's toes and reverse the real event order.
This mitigates the problem with getting podman API call results in the wrong order (containers/podman#19124); that causes containers to sometimes appear in a non-current state.
See the above podman issue, this can't be perfect. I stress-tested this in #1324, and at least it got a lot better. E.g. in commit 5a28f0d I just got one failure out of 5x3x13 runs (amplification x affected retries x TEST_OS). But it makes runs a lot easier to get green.