Support uploading files with administrator privileges #845
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Files could not yet support uploading to non-logged in user directories as these files would always be uploaded as `root:root` and this might not be wanted in directories not owned by `root`. This change will bring the upload support in line with what we already did for creating a new file and directory. When uploading to a directory not owned by the current user give the user to pick the expected ownership for all to be uploaded files.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -204,6 +297,11 @@ | |||
| return; | |||
| } | |||
|
|
|||
| function resetUnload() { | |||
Check notice
Code scanning / CodeQL
Unused variable, import, function or class Note
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Files could not yet support uploading to non-logged in user directories as these files would always be uploaded as
root:rootand this might not be wanted in directories not owned byroot.This change will bring the upload support in line with what we already did for creating a new file and directory. When uploading to a directory not owned by the current user give the user to pick the expected ownership for all to be uploaded files.
Required test cases:
admin:adminroottestuser:testuserAllow uploading everywhere