Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pathbar: Edit should not be inside the pathbar widget #640

Closed
garrett opened this issue Jul 11, 2024 · 4 comments
Closed

pathbar: Edit should not be inside the pathbar widget #640

garrett opened this issue Jul 11, 2024 · 4 comments
Labels
bug Something isn't working

Comments

@garrett
Copy link
Member

garrett commented Jul 11, 2024

The edit button is currently inside the pathbar. It should be outside of the pathbar and the pathbar should just contain path widgetry.

@garrett garrett added the bug Something isn't working label Jul 11, 2024
@jelly
Copy link
Member

jelly commented Jul 15, 2024

I don't fully understand what the pathbar widget is? The edit button is inside a PageBreadCrumb which honestly seems fine. We need to put this all in one nav item so it appears in one bar.

@garrett
Copy link
Member Author

garrett commented Jul 17, 2024

In other words: "Edit button should not be inside the breadcrumbs component".

It's not fine, unless the edit button is a location you go to that's above the top of the filesystem @ /.

@jelly
Copy link
Member

jelly commented Jul 22, 2024

Note that I talk about a PageBreadCrumb ie. this which is basically a bar which spawns the full width. So you are saying we should use another bar like this and wrap PageBreadCrumb inside that? And then likely hack around in css?

@garrett
Copy link
Member Author

garrett commented Jul 23, 2024

Should it be something like <PageSection variant={PageSectionVariants.light}> ? That's what the examples @ https://www.patternfly.org/patterns/about-patterns seem to use. And have the items, including the breadcrumbs inside?

jelly added a commit to jelly/cockpit-navigator that referenced this issue Jul 30, 2024
PatternFly has a breadcrumb component which we where not using but
instead used a button which meant we could not properly support middle
click and needed to apply CSS workarounds to style them properly.

Additionally this drops the hostname from the breadcrumb and replaces it
with an icon (with a tooltip).

Middle mouse click now properly works and opens the clicked path in a
new tab.

Closes: cockpit-project#640 cockpit-project#641
jelly added a commit to jelly/cockpit-navigator that referenced this issue Jul 30, 2024
PatternFly has a breadcrumb component which we where not using but
instead used a button which meant we could not properly support middle
click and needed to apply CSS workarounds to style them properly.

Additionally this drops the hostname from the breadcrumb and replaces it
with an icon (with a tooltip).

Middle mouse click now properly works and opens the clicked path in a
new tab.

Closes: cockpit-project#640 cockpit-project#641
jelly added a commit to jelly/cockpit-navigator that referenced this issue Jul 30, 2024
PatternFly has a breadcrumb component which we where not using but
instead used a button which meant we could not properly support middle
click and needed to apply CSS workarounds to style them properly.

Additionally this drops the hostname from the breadcrumb and replaces it
with an icon (with a tooltip).

Middle mouse click now properly works and opens the clicked path in a
new tab.

Closes: cockpit-project#640 cockpit-project#641
@jelly jelly closed this as completed in 3e1c25e Jul 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants