-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pathbar: Edit should not be inside the pathbar widget #640
Comments
I don't fully understand what the pathbar widget is? The edit button is inside a |
In other words: "Edit button should not be inside the breadcrumbs component". It's not fine, unless the edit button is a location you go to that's above the top of the filesystem @ |
Should it be something like |
PatternFly has a breadcrumb component which we where not using but instead used a button which meant we could not properly support middle click and needed to apply CSS workarounds to style them properly. Additionally this drops the hostname from the breadcrumb and replaces it with an icon (with a tooltip). Middle mouse click now properly works and opens the clicked path in a new tab. Closes: cockpit-project#640 cockpit-project#641
PatternFly has a breadcrumb component which we where not using but instead used a button which meant we could not properly support middle click and needed to apply CSS workarounds to style them properly. Additionally this drops the hostname from the breadcrumb and replaces it with an icon (with a tooltip). Middle mouse click now properly works and opens the clicked path in a new tab. Closes: cockpit-project#640 cockpit-project#641
PatternFly has a breadcrumb component which we where not using but instead used a button which meant we could not properly support middle click and needed to apply CSS workarounds to style them properly. Additionally this drops the hostname from the breadcrumb and replaces it with an icon (with a tooltip). Middle mouse click now properly works and opens the clicked path in a new tab. Closes: cockpit-project#640 cockpit-project#641
The edit button is currently inside the pathbar. It should be outside of the pathbar and the pathbar should just contain path widgetry.
The text was updated successfully, but these errors were encountered: