Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(debug): Adding CLI for testing liquid #83

Merged
merged 2 commits into from
May 5, 2017
Merged

Conversation

epage
Copy link
Member

@epage epage commented Apr 18, 2017

This will allow tools like cobalt to dump their intermediate state so both tools can be debugged independently.

@epage
Copy link
Member Author

epage commented Apr 18, 2017

This causes skeptic tests to fail (on my machine)

For example

test readme_1 ... FAILED
error[E0464]: multiple matching crates for `liquid`
 --> C:\Users\EPAGE~1.AME\AppData\Local\Temp\rust-skeptic.vn1Pegi19gtZ\test.rs:1:23
  |
1 | extern crate skeptic; extern crate liquid; fn main() { use liquid::{LiquidOptions, Renderable, Context, Error};
  |                       ^^^^^^^^^^^^^^^^^^^^
  |
  = note: candidates:
  = note: path: \\?\P:\_OTHER\git\liquid-rust\target\debug\deps\libliquid-52d5eee7cd2f0e12.rlib
  = note: crate name: liquid
  = note: path: \\?\P:\_OTHER\git\liquid-rust\target\debug\deps\libliquid-82a0161f352a3810.rlib
  = note: crate name: liquid
  = note: path: \\?\P:\_OTHER\git\liquid-rust\target\debug\deps\libliquid-0487cd98885ec900.rlib
  = note: crate name: liquid
  = note: path: \\?\P:\_OTHER\git\liquid-rust\target\debug\deps\libliquid-418804126e8745a1.rlib
  = note: crate name: liquid
  = note: crate name: liquid
  = note: crate name: liquid

Any ideas what is going on?

EDIT: Resolved through a combination of dependency upgrades and removing the caching of the target folder in the CI

Note: this relies on a nightly Cargo.toml feature `required-features`.
Under stable, you will see a warning about an unsupported option and then
the build will fail due to a missing `clap` unless you specify
`--features=cli`.
toml isn't supported for now due to some problems.

To help with this, we are now doing test builds across various features to
make sure that both with and without the features works.
@epage
Copy link
Member Author

epage commented May 5, 2017

CI failure is only on nightly and due to Clippy

@epage epage merged commit f9c82c7 into cobalt-org:master May 5, 2017
@epage epage deleted the dbg branch May 5, 2017 02:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant