Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement contains operator #155

Closed
epage opened this issue Dec 29, 2017 · 0 comments
Closed

Implement contains operator #155

epage opened this issue Dec 29, 2017 · 0 comments
Assignees
@epage
Labels
enhancement Improve the expected std-compatibility Jekyll flavor of liquid
Milestone
0.14

Comments

@epage
Copy link
Member

epage commented Dec 29, 2017

The parser is implemented but does nothing.

Contains should check substrings or array containment

See https://shopify.github.io/liquid/basics/operators/
@epage epage added enhancement Improve the expected std-compatibility Jekyll flavor of liquid labels Dec 29, 2017
@epage epage mentioned this issue Dec 29, 2017
Open
@epage epage added this to the 0.14 milestone Jan 7, 2018
@epage epage self-assigned this Jan 7, 2018
This was referenced Jan 9, 2018
Closed
Merged
badboy added a commit to badboy/liquid-rust that referenced this issue Jan 9, 2018
@badboy
feat: Implement contains operator
6aaa0df 
The contains operator works for strings (substring search), arrays
(string in array) or objects (string key exists).
The renderer will error if the right-hand side operator does not
evaluate to a string, if the left-hand side is neither a string, array
nor object or if the array contains non-string items.

Fixes cobalt-org#155
badboy added a commit to badboy/liquid-rust that referenced this issue Jan 9, 2018
@badboy
feat: Implement contains operator
928d08a 
The contains operator works for strings (substring search), arrays
(string in array) or objects (string key exists).
The renderer will error if the right-hand side operator does not
evaluate to a string, if the left-hand side is neither a string, array
nor object or if the array contains non-string items.

Fixes cobalt-org#155
badboy added a commit to badboy/liquid-rust that referenced this issue Jan 9, 2018
@badboy
feat: Implement contains operator
9703131 
The contains operator works for strings (substring search), arrays
(string in array) or objects (string key exists).
The renderer will error if the right-hand side operator does not
evaluate to a string, if the left-hand side is neither a string, array
nor object or if the array contains non-string items.

Fixes cobalt-org#155
badboy added a commit to badboy/liquid-rust that referenced this issue Jan 9, 2018
@badboy
feat: Implement contains operator
0172b32 
The contains operator works for strings (substring search), arrays
(string in array) or objects (string key exists).
The renderer will error if the right-hand side operator does not
evaluate to a string, if the left-hand side is neither a string, array
nor object or if the array contains non-string items.

Fixes cobalt-org#155
@epage epage closed this as completed in a0d2720 Jan 9, 2018
epage added a commit that referenced this issue Jan 10, 2018
@epage
chore: Release 0.13.7
090fbf4 
Features

*   Implement `contains` operator ([a0d2720](a0d2720), closes [#155](#155))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@epage epage

Labels
enhancement Improve the expected std-compatibility Jekyll flavor of liquid
Projects
None yet
Milestone
0.14
Development

No branches or pull requests
1 participant
@epage