-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add timestamp to layouts for cachebusting #254
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This allows layouts to access a millisecond timestamp which can be used for cachebusting (adding a unique string to static assets to get around long caching times in the browser).
So this is adding a timestamp of when a page was generated so we can have a unique value each time we might want to bust caches?
First off, I'll admit (yet again) I'm not a web dev and don't know what the best practices are for cache busting (I've read up on the basic theory).
Would the general recommendation be
- To use the generated-time feature you are adding?
- Write a monotonically non-increasing integer in place of the timestamp and manually bump it? This would be a bit tedious, so some sub-options include
- Side-wide attribute so people can do
<link rel="stylesheet" href="/css/main.css?v={{ cachebuster }}">
- Add support for data files (serde makes it easy for us to even support csvs for this) with all the assets listed out in a data file for easy update throughout the site (so you'd have a link like
<link rel="stylesheet" href="{{ assets.main_css }}">
)
- Side-wide attribute so people can do
- Have cobalt checksum asset files and automatically insert the value, so you'd get links like
<link rel="stylesheet" href="{{ assets.css.main_css.link }}">
)
The downside to the manual integer work is that it requires people to be disciplined about updating the number when they update an asset.
The downsides to using generation-time is that it is less obvious and flushes the caches more often.
The downside of the checksum solution is that it is a bit more involved of a solution.
Thoughts?
@@ -0,0 +1,7 @@ | |||
extends: default.liquid | |||
--- | |||
This is my Index page! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If your goal is to test the timestamp feature, is there a reason to have posts, or having the timestamp in the file you extend rather than having it in your actual index.liquid?
Boiling down tests to cover only the feature in question helps to make the tests more stable and reduces churn when something unrelated changes that causes either minor tweaks (like syntect
making slight layout changes) or major ones (us breaking compatibility as we work towards 1.0).
@@ -176,12 +176,15 @@ pub fn build(config: &Config) -> Result<()> { | |||
.collect(); | |||
|
|||
trace!("Generating other documents"); | |||
let timestamp = Value::Str(UTC::now().timestamp().to_string()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I used Value::Str since Value::Num only accepts f32 - the timestamp is i64 so casting to f32 trims the number to the point where it's not unique.
liquid-rust/#88 will require us to have integer values. So in the future we can change this.
Note: overall, I think it might be useful to have some kind of "generated-time" value but I'd expect it to parallel the eventual "published-time" and "last-modified-time" attributes which would all be in date formats. If it doesn't exist, we could add a liquid filter to turn a datetime into an integer value. So if we decide a checksum solution is best but you want a solution now, reframing this as "generated-time" timestamp might work out. |
You're right, this would end up breaking the cache each time a build is run, so if you're creating a post a day it'd have a pretty detrimental affect on caching (the opposite of what we want!) I think it makes sense to turn this into the |
cobalt already copies over every asset, so it can easily get a checksum as it goes. Building up a |
This allows layouts to access a millisecond timestamp which can be used for cachebusting (adding a unique string to static assets to get around long caching times in the browser).
Notes
Value::Str
sinceValue::Num
only acceptsf32
- the timestamp isi64
so casting tof32
trims the number to the point where it's not unique.build
command is run - this means the target to compare with needs to be built whencargo test
runs.date
instead oftimestamp
and then format in the layout file - this would give users more flexibility since they can access the Date object, but would mean each asset would have to format the date individually.