Convert parser tests to suite format, part 3 #1284
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Izaakwltn
approved these changes
Oct 2, 2024
| error: Malformed monomophize attribute | ||
| --> test:3:0 | ||
| | | ||
| 3 | (monomorphize 5) |
There was a problem hiding this comment.
Error message: This should probably be either "unexpected trailing form", pointing at only 5, or something monomorphize specific like "monomorphize takes no arguments"
| error: Unknown repr attribute | ||
| --> test:3:6 | ||
| | | ||
| 3 | (repr :hello) |
There was a problem hiding this comment.
(repr :hello) should be added, right? /s
|
|
||
| (package coalton-unit-tests) | ||
|
|
||
| (monomorphize) |
There was a problem hiding this comment.
(monomorphize)
(declare x UFix)
(define x 2)
There was a problem hiding this comment.
you can take off (:disable) :)
jbouwman
force-pushed
the
test-suite-3
branch
2 times, most recently
from
2ab00cc to
a1237ca
Compare
- convert and, attribute, body, break, cond, continue, declare, let, toplevel
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge individual test cases into per-function files according to model established in #1274, #1278
Several test cases which parse but do not compile are disabled pending review according to comments in #1272, #1274, #1278