Rust Clippy #1467

rubdos · 2017-02-27T17:55:00Z

This is mostly finished now. This integrates rust-clippy with coala, which is the de-facto standard linter for Rust.

I had to work around some stuff. CircleCI uses a rewrite for github clone urls in their default .gitconfig file. As cargo, which is the Rust package manager, doesn't like that, I had to circumvent that. When this issue, which I am tracking, closes, I'll come and remove the workaround. It consists of the git config --global --unset url.ssh://[email protected]:.insteadof option in checkout: post, and the if test in the .ci/deps.sh file. The if test is there to distinguish CircleCI from travis at that point.

On Windows, the clippy linter needs some weird directories in its PATH, because of this Rust bug.

All workarounds are annotated in the source code.

Checklist

I read the commit guidelines and I've followed
them.
I ran coala over my code locally. (All commits have to pass
individually. It is not sufficient to have "fixup commits" on your PR,
our bot will still report the issues for the previous commit.) You will
likely receive a lot of bot comments and build failures if coala does not
pass on every single commit!

TODO

Use rustup.rs instead of rustup.sh. The former is the successor of the latter. We don't want to have to change that, if we can have it today! :)
@jayvdb says this is blocked on Bear.get_config_dir() has different behaviour on Windows versus Linux coala#3867

gitmate-bot · 2017-02-27T17:56:16Z

bears/rust/RustClippyLintBear.py

+            return True
+
+    def run(self):
+        args = ('clippy', '--quiet', '--color', 'never', '--', '-Z', 'unstable-options', '--error-format', 'json', '--test')


E501 line too long (124 > 79 characters)'

PycodestyleBear (E501), severity NORMAL, section autopep8.

gitmate-bot · 2017-02-27T17:56:17Z

bears/rust/RustClippyLintBear.py

+    AUTHORS = {'The coala developers'}
+    AUTHORS_EMAILS = {'[email protected]'}
+    LICENSE = 'AGPL-3.0'
+    CAN_DETECT = {'Formatting', 'Unused Code', 'Syntax', 'Unreachable Code', 'Smell', 'Code Simplification'}


E501 line too long (108 > 79 characters)'

PycodestyleBear (E501), severity NORMAL, section autopep8.

gitmate-bot · 2017-02-27T17:56:18Z

bears/rust/RustClippyLintBear.py

+            return True
+
+    def run(self):
+        args = ('clippy', '--quiet', '--color', 'never', '--', '-Z', 'unstable-options', '--error-format', 'json', '--test')


The code does not comply to PEP8.

PEP8Bear, severity NORMAL, section autopep8.

The issue can be fixed by applying the following patch:

--- a/bears/rust/RustClippyLintBear.py +++ b/bears/rust/RustClippyLintBear.py @@ -31,7 +31,8 @@ return True def run(self): - args = ('clippy', '--quiet', '--color', 'never', '--', '-Z', 'unstable-options', '--error-format', 'json', '--test') + args = ('clippy', '--quiet', '--color', 'never', '--', '-Z', + 'unstable-options', '--error-format', 'json', '--test') _, stderr_output = run_shell_command( (self.EXECUTABLE,) + args, cwd=self.get_config_dir(),

gitmate-bot · 2017-02-27T17:56:19Z

bears/rust/RustClippyLintBear.py

+    AUTHORS = {'The coala developers'}
+    AUTHORS_EMAILS = {'[email protected]'}
+    LICENSE = 'AGPL-3.0'
+    CAN_DETECT = {'Formatting', 'Unused Code', 'Syntax', 'Unreachable Code', 'Smell', 'Code Simplification'}


The code does not comply to PEP8.

PEP8Bear, severity NORMAL, section autopep8.

The issue can be fixed by applying the following patch:

--- a/bears/rust/RustClippyLintBear.py +++ b/bears/rust/RustClippyLintBear.py @@ -13,7 +13,8 @@ AUTHORS = {'The coala developers'} AUTHORS_EMAILS = {'[email protected]'} LICENSE = 'AGPL-3.0' - CAN_DETECT = {'Formatting', 'Unused Code', 'Syntax', 'Unreachable Code', 'Smell', 'Code Simplification'} + CAN_DETECT = {'Formatting', 'Unused Code', 'Syntax', + 'Unreachable Code', 'Smell', 'Code Simplification'} EXECUTABLE = 'cargo' SEVERITY_MAP = { # TODO: are there more?

gitmate-bot · 2017-02-27T17:56:20Z

bears/rust/RustClippyLintBear.py

+            return True
+
+    def run(self):
+        args = ('clippy', '--quiet', '--color', 'never', '--', '-Z', 'unstable-options', '--error-format', 'json', '--test')


Line is longer than allowed. (124 > 79)

LineLengthBear, severity NORMAL, section linelength.

gitmate-bot · 2017-02-27T17:56:21Z

Comment on 83391bd.

Shortlog of HEAD commit contains a period at end.

GitCommitBear, severity NORMAL, section commit.

gitmate-bot · 2017-02-27T17:56:21Z

bears/rust/RustClippyLintBear.py

+    AUTHORS = {'The coala developers'}
+    AUTHORS_EMAILS = {'[email protected]'}
+    LICENSE = 'AGPL-3.0'
+    CAN_DETECT = {'Formatting', 'Unused Code', 'Syntax', 'Unreachable Code', 'Smell', 'Code Simplification'}


Line is longer than allowed. (108 > 79)

LineLengthBear, severity NORMAL, section linelength.

gitmate-bot · 2017-02-27T18:33:03Z

Comment on ce2c3df.

Shortlog of HEAD commit contains a period at end.

GitCommitBear, severity NORMAL, section commit.

gitmate-bot · 2017-02-28T10:47:12Z

Comment on bd35f4d.

Shortlog of HEAD commit contains a period at end.

GitCommitBear, severity NORMAL, section commit.

gitmate-bot · 2017-02-28T11:56:16Z

Comment on 588e4d2.

Shortlog of HEAD commit contains a period at end.

GitCommitBear, severity NORMAL, section commit.

gitmate-bot · 2017-02-28T12:24:30Z

Comment on 3bd43b3.

Shortlog of HEAD commit contains a period at end.

GitCommitBear, severity NORMAL, section commit.

gitmate-bot · 2017-02-28T13:51:40Z

Comment on c6e97fd.

Shortlog of HEAD commit isn't in imperative mood! Bad words are 'Debugging'

GitCommitBear, severity NORMAL, section commit.

gitmate-bot · 2017-10-16T15:14:09Z

Hey! This pull request is being rebased automatically. Please DO NOT push while rebase is in progress or your changes would be lost!

Closes coala#50

gitmate-bot · 2017-10-16T15:14:19Z

Automated rebase was successful!

sils · 2017-10-16T15:18:11Z

ack 86803af

sils · 2017-10-16T15:36:45Z

tests/rust/RustClippyLintBearTest.py

+        self.assertTrue(len(results) == 1)
+
+        result = results[0]
+        print(result)


darn, spotted a print statement, I wanted to ack this!

sils · 2017-10-16T15:37:14Z

reack 07508cf

sils · 2017-10-16T15:44:01Z

unack 07508cf I meant...

sils · 2017-10-16T15:46:40Z

ack 1e21230

sils · 2017-10-16T15:48:16Z

From circle coala logs:

[DEBUG][15:39:49] The bear GitCommitBear raised an exception. If you are the author of this bear, please make sure to catch all exceptions. If not and this error annoys you, you might want to get in contact with the author of this bear.

Traceback information is provided below:

Traceback (most recent call last):
  File "/home/ubuntu/.pyenv/versions/3.5.1/lib/python3.5/site-packages/coalib/bears/Bear.py", line 308, in execute
    return [] if result is None else list(result)
  File "/home/ubuntu/.pyenv/versions/3.5.1/lib/python3.5/site-packages/bears/vcs/git/GitCommitBear.py", line 134, in run
    **self.get_issue_checks_metadata().filter_parameters(kwargs))
  File "/home/ubuntu/.pyenv/versions/3.5.1/lib/python3.5/site-packages/bears/vcs/git/GitCommitBear.py", line 302, in check_issue_reference
    body = body.splitlines()[-1]
IndexError: list index out of range

sils · 2017-10-16T15:49:52Z

ack f10714f

sils · 2017-10-16T15:50:18Z

ack 6ea0d82

sils · 2017-10-16T15:53:38Z

@rubdos IIUC just remove the print stmt, add a body to the last commit message and file an issue about gitcommitbear should do the trick.

gitmate-bot added process/wip size/M labels Feb 27, 2017

gitmate-bot reviewed Feb 27, 2017

View reviewed changes

rubdos force-pushed the rust-clippy branch from 83391bd to ce2c3df Compare February 27, 2017 18:31

rubdos force-pushed the rust-clippy branch from ce2c3df to 3418e5c Compare February 27, 2017 18:33

gitmate-bot added size/L and removed size/M labels Feb 28, 2017

rubdos force-pushed the rust-clippy branch from bd35f4d to 0efee95 Compare February 28, 2017 10:57

rubdos force-pushed the rust-clippy branch from 588e4d2 to 66d2685 Compare February 28, 2017 12:07

rubdos force-pushed the rust-clippy branch 3 times, most recently from 7cb9ae4 to 7688df3 Compare February 28, 2017 13:02

gitmate-bot added size/XL and removed size/L labels Feb 28, 2017

rubdos force-pushed the rust-clippy branch from 7688df3 to c6e97fd Compare February 28, 2017 13:49

rubdos force-pushed the rust-clippy branch from c6e97fd to 199f6c0 Compare February 28, 2017 14:31

gitmate-bot added the review carefully! label Feb 28, 2017

rubdos force-pushed the rust-clippy branch 2 times, most recently from e9a43e7 to 493bbaf Compare February 28, 2017 14:52

gitmate-bot removed the status/STALE label Oct 16, 2017

rubdos added 5 commits October 16, 2017 15:14

Enable Rust on CircleCI

f10714f

Enable Rust on Travis CI

1e21230

Enable Rust on Appveyor CI

6ea0d82

RustClippyLintBear: Linter support for Rust code

07508cf

Closes coala#50

Add Rust to README.md

86803af

gitmate-bot force-pushed the rust-clippy branch from e8ea12c to 86803af Compare October 16, 2017 15:14

gitmate-bot added size/M status/STALE and removed size/XXL labels Oct 16, 2017

gitmate-bot assigned rubdos Oct 16, 2017

gitmate-bot removed the status/STALE label Oct 16, 2017

coala deleted a comment from gitmate-bot Oct 16, 2017

sils reviewed Oct 16, 2017

View reviewed changes

sils added process/wip and removed process/pending review labels Oct 16, 2017

gitmate-bot added the status/STALE label Oct 24, 2017

gitmate-bot assigned sangamcse Apr 28, 2018

sangamcse removed their assignment Jan 5, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Rust Clippy #1467

Rust Clippy #1467

rubdos commented Feb 27, 2017 •

edited

Loading

gitmate-bot Feb 27, 2017

gitmate-bot Feb 27, 2017

gitmate-bot Feb 27, 2017

gitmate-bot Feb 27, 2017

gitmate-bot Feb 27, 2017

gitmate-bot commented Feb 27, 2017

gitmate-bot Feb 27, 2017

gitmate-bot commented Feb 27, 2017

gitmate-bot commented Feb 28, 2017

gitmate-bot commented Feb 28, 2017

gitmate-bot commented Feb 28, 2017

gitmate-bot commented Feb 28, 2017

gitmate-bot commented Oct 16, 2017

gitmate-bot commented Oct 16, 2017

sils commented Oct 16, 2017

sils Oct 16, 2017

sils commented Oct 16, 2017

sils commented Oct 16, 2017

sils commented Oct 16, 2017

sils commented Oct 16, 2017

sils commented Oct 16, 2017

sils commented Oct 16, 2017

sils commented Oct 16, 2017

Rust Clippy #1467

Are you sure you want to change the base?

Rust Clippy #1467

Conversation

rubdos commented Feb 27, 2017 • edited Loading

Checklist

TODO

gitmate-bot Feb 27, 2017

Choose a reason for hiding this comment

gitmate-bot Feb 27, 2017

Choose a reason for hiding this comment

gitmate-bot Feb 27, 2017

Choose a reason for hiding this comment

gitmate-bot Feb 27, 2017

Choose a reason for hiding this comment

gitmate-bot Feb 27, 2017

Choose a reason for hiding this comment

gitmate-bot commented Feb 27, 2017

gitmate-bot Feb 27, 2017

Choose a reason for hiding this comment

gitmate-bot commented Feb 27, 2017

gitmate-bot commented Feb 28, 2017

gitmate-bot commented Feb 28, 2017

gitmate-bot commented Feb 28, 2017

gitmate-bot commented Feb 28, 2017

gitmate-bot commented Oct 16, 2017

gitmate-bot commented Oct 16, 2017

sils commented Oct 16, 2017

sils Oct 16, 2017

Choose a reason for hiding this comment

sils commented Oct 16, 2017

sils commented Oct 16, 2017

sils commented Oct 16, 2017

sils commented Oct 16, 2017

sils commented Oct 16, 2017

sils commented Oct 16, 2017

sils commented Oct 16, 2017

rubdos commented Feb 27, 2017 •

edited

Loading