Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bear Proposal copyright violation check bear #2108

Open
co-robo opened this issue Nov 2, 2017 · 14 comments
Open

Bear Proposal copyright violation check bear #2108

co-robo opened this issue Nov 2, 2017 · 14 comments

Comments

@co-robo
Copy link

co-robo commented Nov 2, 2017

difficulty/high importance/high
Opened by @jayvdb at Gitter

@gitmate-bot
Copy link
Collaborator

GitMate.io thinks the contributor most likely able to help you is @coala-bot.

@ishanSrt
Copy link

How should one proceed with this?

@Makman2
Copy link
Member

Makman2 commented Jan 21, 2018

@ishanSrt There are some copyright checking tools out there. Actually I think we even have specific issues for them, could you look around in the issue-tracker here?

@Mohit17067
Copy link
Member

I would like to work on this. How should I proceed?

@Makman2
Copy link
Member

Makman2 commented Feb 22, 2018

Find a copyright check tool and lookup in our docs how to write bears.

@Mohit17067
Copy link
Member

@Makman2 Got a doubt, Shouldn't all the bears already made will have to add a copyright notice to them.

@Mohit17067
Copy link
Member

Could you please explain the issue a bit more that when will the bear check for copyright and what's the exact meaning of bear 'proposal' here?

@Makman2
Copy link
Member

Makman2 commented Feb 22, 2018

You have to write a new bear that implements different settings for performing copyright checks. For example the bear can enforce that every file needs a comment with license, or that there has to be just one file in the whole repo.

Shouldn't all the bears already made will have to add a copyright notice to them.

No, one copyright notice for a repo is enough. This is not about enforcing copyright standards in this repo, but to write a bear that is able to do it.

@Mohit17067
Copy link
Member

There is a license_check_files folder for testing licenseCheckBear. So can I use those same files to test this bear as it will be useless to make separate similar files? @Makman2

Mohit17067 added a commit to Mohit17067/coala-bears that referenced this issue Feb 26, 2018
This adds a Copyright notice check bear.

Closes coala#2108
Mohit17067 added a commit to Mohit17067/coala-bears that referenced this issue Feb 26, 2018
This adds a Copyright notice check bear.

Closes coala#2108
@Makman2
Copy link
Member

Makman2 commented Feb 26, 2018

Rather copy them, then changes in one or another location won't affect each other's tests.

Mohit17067 added a commit to Mohit17067/coala-bears that referenced this issue Feb 26, 2018
This adds a Copyright notice check bear.

Closes coala#2108
Mohit17067 added a commit to Mohit17067/coala-bears that referenced this issue Mar 2, 2018
This adds a Copyright notice check bear.
User can specify author if required.

Closes coala#2108
Mohit17067 added a commit to Mohit17067/coala-bears that referenced this issue Mar 3, 2018
This adds a Copyright notice check bear.
User can specify author if required.

Closes coala#2108
Mohit17067 added a commit to Mohit17067/coala-bears that referenced this issue Mar 3, 2018
This adds a Copyright notice check bear.
User can specify author if required.

Closes coala#2108
Mohit17067 added a commit to Mohit17067/coala-bears that referenced this issue Mar 8, 2018
This adds a Copyright notice check bear.
User can specify author if required.

Closes coala#2108
@yash-nisar
Copy link
Member

@jayvdb Do we have to add a new bear or improve the existing LicenseCheckBear and add the copyright checking functionality as you've mentioned here ?

@jayvdb
Copy link
Member

jayvdb commented Mar 11, 2018

this isnt licensing checking. this is copying detection. (ala turnitin)

for our documentation, we should never have text which copies prior text

@jayvdb jayvdb changed the title Bear Proposal copyright check bear Bear Proposal copyright violation check bear Apr 16, 2018
@jayvdb
Copy link
Member

jayvdb commented Apr 16, 2018

The copyright license header bear proposal is #823

@jayvdb
Copy link
Member

jayvdb commented Apr 16, 2018

And #2442 is for a new native license header bear.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

7 participants