Skip to content

Commit

Permalink
requirements: Remove setuptools
Browse files Browse the repository at this point in the history
Pip automatically tells if setuptools is not installed when doing a
source install, and on wheel installs the setuptools is not needed as
the setup.py file doesn't exist anymore.
Also, coala will normally be installed using wheels in pip 6.x+ because
we upload wheels. Hence, we don't need setuptools.

The older versions of pip are anyway not being supported because we use
the ~= syntax. And the older versions of pip will just throw an import
error at the setuptools.

Hence, the setuptools in requirements.txt has no purpose other than
forcing the user to upgrade the setuptools above the lower version we
specify.

Fixes #751
  • Loading branch information
AbdealiLoKo committed Sep 3, 2016
1 parent 99958eb commit 98a4054
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion requirements.txt
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
# Use >= for development versions so that source builds always work
coala>=0.8.0
setuptools>=19.2
munkres3==1.*
pylint==1.*
language-check==0.8.*
Expand Down

0 comments on commit 98a4054

Please sign in to comment.