Feature/ucd 36 custom application history page #279
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove the history records from Person (and derived classes) and Registrant as it is not used by the admins.
Check if we are on local environment before trying to send the emails. This will enable us to test the model updates without any interruptions on local testing.
Customise the review history so that it shows the summary of application status changes along with the changes done in the review. To provide this, we had to override the /simple_history/object_history.html so we keep the default behaviour for all other types. In the status summary table, we filter out similar records and only display the latest record of the similar group. For detailed information, the user can view the relevant application's history under Applications.
dhvander
requested review from
jinnashravan,
jimnarey,
prakash-gds and
maxf
Disable change on the following entities 1. Registrar 2. Registrant 3. RegistryPublishedPerson 4. RegistrantPerson 5. RegistrarPerson
maxf
requested changes
Sep 10, 2024
| <th scope="col">{% trans 'Date/time' %}</th> | ||
| <th scope="col">{% trans 'Event' %}</th> | ||
| <th scope="col">{% trans 'Changed by' %}</th> | ||
| <th scope="col">{% trans 'Change fields' %}</th> |
There was a problem hiding this comment.
"Changed Fields" is better I think
| {% endif %} | ||
| </td> | ||
| <td> | ||
| <i>{{ action | changed_fields }}</i> |
There was a problem hiding this comment.
Why <i>? I don't think it's needed. It actually makes the text harder to read. Maybe you could also use something to join using commas as opposed to displaying the raw string. Better abc, def than ['abc', 'def']
|
|
||
| {% block content %} | ||
| <div id="content-main"> | ||
| <h2>{% blocktrans %} Status change history{% endblocktrans %}</h2> |
| @@ -58,25 +64,23 @@ <h2>Full event history</h2> | |||
| <thead> | |||
| <tr> | |||
| <th scope="col">{% trans 'Date/time' %}</th> | |||
| <th scope="col">{% trans 'Event' %}</th> | |||
| <th scope="col">{% trans 'Changed by' %}</th> | |||
| <th scope="col">{% trans 'User' %}</th> | |||
| <th scope="col">{% trans 'Change fields' %}</th> | |||
There was a problem hiding this comment.
"Changed fields" is better I think
| @@ -15,22 +17,49 @@ def changed_fields(obj): | |||
| if obj.prev_record: | |||
| delta = obj.diff_against(obj.prev_record) | |||
| changes = list(filter(lambda x: x != "last_updated_by", delta.changed_fields)) | |||
| return changes if changes else "Updated through review" | |||
| return changes if changes else "--" | |||
There was a problem hiding this comment.
Can you put something more explicit than -- ? What does it mean for the user when there are no changes? Why show entries in the history if there are no changes?
maxf
requested changes
Sep 11, 2024
| @@ -25,7 +25,7 @@ <h2>Full event history</h2> | |||
| <tr> | |||
| <th scope="col">{% trans 'Date/time' %}</th> | |||
| <th scope="col">{% trans 'User' %}</th> | |||
| <th scope="col">{% trans 'Change fields' %}</th> | |||
| <th scope="col">{% trans 'Change Fields' %}</th> | |||
| @@ -65,7 +65,7 @@ <h2>Full event history</h2> | |||
| <tr> | |||
| <th scope="col">{% trans 'Date/time' %}</th> | |||
| <th scope="col">{% trans 'User' %}</th> | |||
| <th scope="col">{% trans 'Change fields' %}</th> | |||
| <th scope="col">{% trans 'Change Fields' %}</th> | |||
| @@ -17,8 +17,8 @@ def changed_fields(obj): | |||
| if obj.prev_record: | |||
| delta = obj.diff_against(obj.prev_record) | |||
| changes = list(filter(lambda x: x != "last_updated_by", delta.changed_fields)) | |||
| return changes if changes else "--" | |||
| return "-" | |||
| return ", ".join(changes) if changes else "No Changes" | |||
dhvander
force-pushed
the
feature/UCD_36-custom-application-history-page
branch
from
e7cfc72
to
fba6e57
Compare
Updated the UI to make it more user-friendly.
dhvander
force-pushed
the
feature/UCD_36-custom-application-history-page
branch
from
fba6e57
to
f94ad84
Compare
maxf
approved these changes
Sep 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Customise the review history so that it shows the summary of application status changes along with the changes done in the review.
To provide this, we had to override the /simple_history/object_history.html so we keep the default behaviour for all other types.
In the status summary table, we filter out similar records and only display the latest record of the similar group. For detailed information, the user can view the relevant application's history under Applications.