Remove S3 urls from application UI #210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prakash-gds
approved these changes
Jun 12, 2024
dhvander
force-pushed
the
feature/file-upload-s3-changes
branch
from
f4713fe
to
1254322
Compare
This is done by doing the following. - When uploading files, always upload to a folder called temporary_files. - Update the save method of the application, so that we copy any files still pointing to the temporary_files folder and pint to the new location (applications/<application reference>) for each file field. Also, the old file is deleted from the temporary location. - Implement new view method to retrieve the file from S3 and serve instead of exposing the S3 urls. The application pages as well as the admin pages have been updated with specific view methods to download temporary as well as application related files. - Increase the width of the file field columns to 255 so we can store the file paths
dhvander
force-pushed
the
feature/file-upload-s3-changes
branch
from
1254322
to
4d5054f
Compare
Sample data population had to be modified in order to simulate the availability of files in the /temp_files folder on AWS. Also the init task had to be in the same network as S3 to access the mock bucket.
dhvander
force-pushed
the
feature/file-upload-s3-changes
branch
from
4d5054f
to
b8e1e9c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is done by doing the following.