feat: update of the plugin to use DOMInformations

cnumr · Apr 9, 2024 · 31edba3 · 31edba3
1 parent e80e8c2
commit 31edba3
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 18 deletions.
diff --git a/lighthouse-plugin-ecoindex/audits/commons.js b/lighthouse-plugin-ecoindex/audits/commons.js
@@ -1,8 +1,8 @@
 export default {
-    requiredArtifacts: [
-        'MainDocumentContent',
-        'DOMStats',
-        'devtoolsLogs',
-        'DOMInformations',
-      ]
-}
+  requiredArtifacts: [
+    'MainDocumentContent',
+    'DOMStats',
+    'devtoolsLogs',
+    'DOMInformations',
+  ],
+}
diff --git a/lighthouse-plugin-ecoindex/utils/index.js b/lighthouse-plugin-ecoindex/utils/index.js
@@ -18,18 +18,18 @@ export const B_TO_KB = 1000
  * @returns number
  */
 export async function getEcoindexNodes(artifacts) {
-  if (!artifacts.DOMInformations) {
-    // throw new Error(
-    //   "DOMInformations not found, EcoindexNodes can't be calculated.",
-    // )
-    const MainDocumentContent = artifacts.MainDocumentContent
-    const dom = new JSDOM(MainDocumentContent)
-    const allNodes = dom.window.document.querySelectorAll('*').length
-    const svgContentNodes = dom.window.document.querySelectorAll('svg *').length
-    return allNodes - svgContentNodes
-  }
+  // if (!artifacts.DOMInformations) {
+  //   throw new Error(
+  //     "DOMInformations not found, EcoindexNodes can't be calculated.",
+  //   )
+  //   const MainDocumentContent = artifacts.MainDocumentContent
+  //   const dom = new JSDOM(MainDocumentContent)
+  //   const allNodes = dom.window.document.querySelectorAll('*').length
+  //   const svgContentNodes = dom.window.document.querySelectorAll('svg *').length
+  //   return allNodes - svgContentNodes
+  // }
   const domInformations = artifacts.DOMInformations
-  console.debug(`domInformations`, domInformations)
+  // console.debug(`domInformations`, domInformations)
   return domInformations.nodesBodyWithoutSVGChildsCount
 }