Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document dfr/reduce-+ & dfr/reduce-* #104

Merged
merged 2 commits into from
Sep 9, 2024

Conversation

shellandbull
Copy link
Contributor

Documents the methods reduce-+ and reduce-* - cheers to @daslu for pairing with me on this one 🌞

Copy link
Owner

@cnuernber cnuernber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me so far! Thanks.

@shellandbull
Copy link
Contributor Author

@cnuernber thanks, it's a pleasure meeting you Chris 😄 let me add a few more and mark this as ready for review

@shellandbull shellandbull marked this pull request as ready for review August 4, 2024 20:05
@shellandbull
Copy link
Contributor Author

@cnuernber Hello there, this is now ready for a review and merge 😸 I documented all the other functions named like reduce-

@cnuernber cnuernber merged commit 9de4bfe into cnuernber:master Sep 9, 2024
@shellandbull
Copy link
Contributor Author

🎊 🎊 🎊 🎊 My first Clojure PR is now merged!

@harold
Copy link
Collaborator

harold commented Sep 10, 2024

@shellandbull - very cool accomplishment. 👏

Here's a similar(-ish) issue, in case that's of interest: techascent/tech.ml.dataset#412

(cc: @daslu)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants