Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add mars3d plugins #312

Merged
merged 1 commit into from
Oct 30, 2024
Merged

feat: add mars3d plugins #312

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9819,6 +9819,24 @@
"mars3d-cesium": {
"version": "*"
},
"mars3d-echarts": {
"version": "*"
},
"mars3d-heatmap": {
"version": "*"
},
"mars3d-mapv": {
"version": "*"
},
"mars3d-space": {
"version": "*"
},
"mars3d-tdt": {
"version": "*"
},
"mars3d-wind": {
"version": "*"
},
Comment on lines +9822 to +9839
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codebase verification

⚠️ Potential issue

Update version constraints to match verified package versions

Based on the npm registry verification:

  1. All packages are legitimate mars3d plugins
  2. They all follow the same major version (3.x.x)
  3. The core mars3d package is also present but using "*"

Suggest updating the version constraints to:

-    "mars3d": {
-      "version": "*"
-    },
-    "mars3d-echarts": {
-      "version": "*"
-    },
-    "mars3d-heatmap": {
-      "version": "*" 
-    },
-    "mars3d-mapv": {
-      "version": "*"
-    },
-    "mars3d-space": {
-      "version": "*"
-    },
-    "mars3d-tdt": {
-      "version": "*"
-    },
-    "mars3d-wind": {
-      "version": "*"
-    }
+    "mars3d": "^3.8.5",
+    "mars3d-echarts": "^3.8.5",
+    "mars3d-heatmap": "^3.8.4",
+    "mars3d-mapv": "^3.8.5", 
+    "mars3d-space": "^3.8.5",
+    "mars3d-tdt": "^3.8.4",
+    "mars3d-wind": "^3.8.5"

Using ^3.8.x ensures compatibility while preventing breaking changes from major version updates.

🔗 Analysis chain

Version constraints should be more specific than wildcard "*"

Using "*" as the version constraint allows any version to be installed, which can lead to unexpected breaking changes and instability. Consider:

  1. Using specific version ranges (e.g. "^1.0.0")
  2. Pinning to exact versions if needed
  3. Following semver best practices

Suggest updating the version constraints to be more specific:

-    "mars3d-echarts": {
-      "version": "*"
-    },
-    "mars3d-heatmap": {
-      "version": "*" 
-    },
-    "mars3d-mapv": {
-      "version": "*"
-    },
-    "mars3d-space": {
-      "version": "*"
-    },
-    "mars3d-tdt": {
-      "version": "*"
-    },
-    "mars3d-wind": {
-      "version": "*"
-    }
+    "mars3d-echarts": "^1.0.0",
+    "mars3d-heatmap": "^1.0.0",
+    "mars3d-mapv": "^1.0.0", 
+    "mars3d-space": "^1.0.0",
+    "mars3d-tdt": "^1.0.0",
+    "mars3d-wind": "^1.0.0"

Let's verify these are legitimate mars3d plugins and check their peer dependencies:

Let me check the npm registry to verify these packages and their available versions. This will help us determine if these are legitimate packages and what version constraints would be appropriate.

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Verify mars3d plugins and their peer dependencies
# Test: Search for mars3d peer dependency declarations
rg -A 5 '"peerDependencies".*mars3d"'

Length of output: 39

Script:

#!/bin/bash
# Let's verify if these are legitimate mars3d plugins by checking npm registry
for pkg in mars3d-echarts mars3d-heatmap mars3d-mapv mars3d-space mars3d-tdt mars3d-wind; do
  echo "=== Checking $pkg ==="
  curl -s "https://registry.npmjs.org/$pkg" | jq -r '. | {name: .name, versions: (if has("versions") then [keys(.versions)] else "Not found" end), "latest": .["dist-tags"].latest}'
done

Length of output: 3629

Script:

#!/bin/bash
# Let's try a simpler approach to check if these packages exist in the npm registry
for pkg in mars3d-echarts mars3d-heatmap mars3d-mapv mars3d-space mars3d-tdt mars3d-wind; do
  echo "=== Checking $pkg ==="
  # Just check if we get a 404 or valid response
  status=$(curl -s -o /dev/null -w "%{http_code}" "https://registry.npmjs.org/$pkg")
  echo "HTTP Status: $status"
  
  if [ "$status" = "200" ]; then
    # If package exists, get its latest version
    curl -s "https://registry.npmjs.org/$pkg/latest" | jq -r '.version'
  fi
done

# Also let's check if mars3d itself is a dependency in package.json
echo -e "\n=== Checking mars3d core dependency ==="
grep -A 2 '"mars3d"' package.json || echo "mars3d core not found in package.json"

Length of output: 2562

"mashi-open-snippets": {
"version": "*"
},
Expand Down
Loading