Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add emoji-datasource-twitter #293

Merged
merged 2 commits into from
Oct 8, 2024
Merged

feat: add emoji-datasource-twitter #293

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3092cc8
Update package.json for adding emoji-datasource-twitter
iwillwen Oct 8, 2024
1f0d68d
Merge branch 'master' into patch-1
fengmk2 Oct 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18638,6 +18638,9 @@
},
"loading-attribute-polyfill": {
"version": "*"
},
"emoji-datasource-twitter": {
"version": "*"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🛠️ Refactor suggestion

⚠️ Potential issue

Consider using a more specific version range for the new dependency.

The addition of "emoji-datasource-twitter" with a wildcard version ("*") allows for any version to be installed. This could potentially lead to unexpected behavior if breaking changes are introduced in future versions. Consider using a more specific version range, such as "^1.0.0" or "~1.0.0", to ensure better stability and predictability in your project.

You can modify the dependency as follows:

-    "emoji-datasource-twitter": {
-      "version": "*"
-    }
+    "emoji-datasource-twitter": "^1.0.0"

Replace "^1.0.0" with the actual version you intend to use, allowing for minor and patch updates while avoiding potential breaking changes from major version updates.

Committable suggestion was skipped due to low confidence.

}
}
}
Loading