Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add web-serial-polyfill #239

Merged
merged 1 commit into from
Aug 7, 2024
Merged

feat: add web-serial-polyfill #239

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17386,6 +17386,9 @@
"web-highlighter": {
"version": "*"
},
"web-serial-polyfill": {
"version": "*"
},
Comment on lines +17389 to +17391
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Specify a version range or specific version for web-serial-polyfill.

Allowing any version (*) can lead to potential issues with compatibility and stability. It's generally recommended to specify a version range or a specific version to ensure consistent behavior.

-    "web-serial-polyfill": {
-      "version": "*"
-    },
+    "web-serial-polyfill": {
+      "version": "^1.0.0"
+    },
Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
"web-serial-polyfill": {
"version": "*"
},
"web-serial-polyfill": {
"version": "^1.0.0"
},

"web-streams-polyfill": {
"version": "*"
},
Expand Down
Loading