-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add echarts-www-landing-animation, echarts-extension-amap, echarts-extension-gmap #176
Conversation
…and `echarts-extension-gmap`
WalkthroughThe Changes
Sequence Diagram(s)No sequence diagrams necessary for these changes. Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Outside diff range and nitpick comments (2)
package.json (2)
4658-4663
: Dependencies for ECharts extensions added correctly.The dependencies
echarts-extension-amap
andecharts-extension-gmap
have been added with a wildcard version specifier. This ensures maximum compatibility but might introduce risks with breaking changes in future updates.Consider specifying more restrictive version ranges to mitigate potential issues with future breaking changes.
4685-4687
: Dependency for ECharts animation added correctly.The dependency
echarts-www-landing-animation
has been added and is consistent with the PR objectives.As with the previous dependencies, consider using a more specific version range instead of a wildcard to avoid issues with non-backward compatible updates.
[skip ci] ## [1.91.0](v1.90.0...v1.91.0) (2024-06-28) ### Features * add echarts-www-landing-animation, echarts-extension-amap, echarts-extension-gmap ([#176](#176)) ([cdf136f](cdf136f))
Summary by CodeRabbit