-
Notifications
You must be signed in to change notification settings - Fork 167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add lxgw-wenkai #106
Conversation
Warning Review failedThe pull request is closed. WalkthroughThe Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"lxgw-wenkai-gb-web": { | ||
"version": "*" | ||
}, | ||
"lxgw-wenkai-screen-web": { | ||
"version": "*" | ||
}, | ||
"lxgw-wenkai-tc-web": { | ||
"version": "*" | ||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider pinning the versions of lxgw-wenkai-gb-web
, lxgw-wenkai-screen-web
, and lxgw-wenkai-tc-web
to specific stable releases.
Using a wildcard for the versions ("version": "*"
) can lead to potential breaking changes if the packages update. Pinning to specific versions can enhance stability and predictability.
"@callmebill/lxgw-wenkai-web": { | ||
"version": "*" | ||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider pinning the version of @callmebill/lxgw-wenkai-web
to a specific stable release.
Using a wildcard for the version ("version": "*"
) can lead to potential breaking changes if the package updates. Pinning to a specific version can enhance stability and predictability.
- Add `@callmebill/lxgw-wenkai-web` as a dependency in package.json - Add `lxgw-wenkai-gb-web` as a dependency in package.json - Add `lxgw-wenkai-screen-web` as a dependency in package.json - Add `lxgw-wenkai-tc-web` as a dependency in package.json Signed-off-by: ysicing <[email protected]>
[skip ci] ## [1.50.0](v1.49.0...v1.50.0) (2024-06-02) ### Features * add lxgw-wenkai ([#106](#106)) ([852be10](852be10))
霞鶩文楷字体
Summary by CodeRabbit