Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add lxgw-wenkai #106

Merged
merged 1 commit into from
Jun 2, 2024
Merged

feat: add lxgw-wenkai #106

merged 1 commit into from
Jun 2, 2024

Conversation

ysicing
Copy link
Contributor

@ysicing ysicing commented Jun 2, 2024

霞鶩文楷字体

Summary by CodeRabbit

  • Chores
    • Updated dependencies to include new font packages for enhanced typography options.

Copy link

coderabbitai bot commented Jun 2, 2024

Warning

Review failed

The pull request is closed.

Walkthrough

The package.json file has been updated to introduce new dependencies, specifically adding several font-related packages: @callmebill/lxgw-wenkai-web, lxgw-wenkai-gb-web, lxgw-wenkai-screen-web, and lxgw-wenkai-tc-web. These additions expand the project's capabilities by incorporating additional font resources, likely enhancing the visual presentation and typography options within the project.

Changes

File Change Summary
package.json Added new dependencies: @callmebill/lxgw-wenkai-web, lxgw-wenkai-gb-web, lxgw-wenkai-screen-web, and lxgw-wenkai-tc-web to include new font resources.

Poem

In the land of code, where bytes do play,
New fonts arrive to save the day.
With Wenkai's grace, our screens now glow,
A typographic marvel in every row.
So cheer, dear devs, for fonts anew,
Our project shines with a vibrant hue! 🌟


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between ce2f3fa and 634661c.

Files selected for processing (1)
  • package.json (2 hunks)

Comment on lines +9107 to +9116
"lxgw-wenkai-gb-web": {
"version": "*"
},
"lxgw-wenkai-screen-web": {
"version": "*"
},
"lxgw-wenkai-tc-web": {
"version": "*"
},
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider pinning the versions of lxgw-wenkai-gb-web, lxgw-wenkai-screen-web, and lxgw-wenkai-tc-web to specific stable releases.

Using a wildcard for the versions ("version": "*") can lead to potential breaking changes if the packages update. Pinning to specific versions can enhance stability and predictability.

Comment on lines +386 to +389
"@callmebill/lxgw-wenkai-web": {
"version": "*"
},
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider pinning the version of @callmebill/lxgw-wenkai-web to a specific stable release.

Using a wildcard for the version ("version": "*") can lead to potential breaking changes if the package updates. Pinning to a specific version can enhance stability and predictability.

- Add `@callmebill/lxgw-wenkai-web` as a dependency in package.json
- Add `lxgw-wenkai-gb-web` as a dependency in package.json
- Add `lxgw-wenkai-screen-web` as a dependency in package.json
- Add `lxgw-wenkai-tc-web` as a dependency in package.json

Signed-off-by: ysicing <[email protected]>
@fengmk2 fengmk2 enabled auto-merge (squash) June 2, 2024 13:45
@fengmk2 fengmk2 merged commit 852be10 into cnpm:master Jun 2, 2024
4 checks passed
fengmk2 pushed a commit that referenced this pull request Jun 2, 2024
[skip ci]

## [1.50.0](v1.49.0...v1.50.0) (2024-06-02)

### Features

* add lxgw-wenkai ([#106](#106)) ([852be10](852be10))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants