This repository has been archived by the owner on Jun 2, 2024. It is now read-only.
Maintainer logic improve #364
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
but admin user need have the permission to delete other's packages.
| @@ -38,6 +38,7 @@ var logger = require('../../common/logger'); | |||
| var ModuleDeps = require('../../proxy/module_deps'); | |||
| var ModuleStar = require('../../proxy/module_star'); | |||
| var ModuleUnpublished = require('../../proxy/module_unpublished'); | |||
| var packageService = require('../../services/package'); | |||
There was a problem hiding this comment.
以后由 service 来封装一下公用的 controller 逻辑代码, service 是对 proxy 操作的合集, 有些复杂逻辑需要去多个数据取数据操作, 都由 service 来封装, 这样能简化controller, 也能更好地让controller减少冗余代码.
|
我再将cnpm info pkg的时候, 获取maintainers 逻辑修改一下 |
|
@dead-horse all done. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#363 #362