Skip to content
This repository has been archived by the owner on Jun 2, 2024. It is now read-only.

feat: impl dist-tag hooks #1612

Merged
merged 2 commits into from
Jan 14, 2021
Merged

feat: impl dist-tag hooks #1612

merged 2 commits into from
Jan 14, 2021

Conversation

killagu
Copy link
Contributor

@killagu killagu commented Jan 13, 2021

No description provided.

@codecov
Copy link

codecov bot commented Jan 13, 2021

Codecov Report

Merging #1612 (5344fda) into master (dffe589) will decrease coverage by 0.26%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1612      +/-   ##
==========================================
- Coverage   87.53%   87.27%   -0.27%     
==========================================
  Files          97       97              
  Lines        4221     4228       +7     
  Branches      809      809              
==========================================
- Hits         3695     3690       -5     
- Misses        526      538      +12     
Impacted Files Coverage Δ
controllers/registry/package/dist_tag.js 100.00% <100.00%> (ø)
controllers/sync_module_worker.js 74.61% <0.00%> (-1.31%) ⬇️
services/package.js 96.99% <0.00%> (-0.26%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dffe589...5344fda. Read the comment docs.

assert(envelope.version === '1.0.1');
assert(envelope.name === '@cnpmtest/dist_tag_test_module_set');
assert(envelope.type === 'package');
assert(envelope.event === 'package:dist-tag');
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tag 的值也加上 assert,下面的测试用例也是。

Copy link
Member

@fengmk2 fengmk2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

其他没有问题了,可以随时合并。

@killagu killagu merged commit 33dd355 into master Jan 14, 2021
@killagu killagu deleted the feat/hooks/dist-tag branch January 14, 2021 02:20
@killagu
Copy link
Contributor Author

killagu commented Jan 14, 2021

+ [email protected]

liuweifeng pushed a commit to liuweifeng/cnpmjs.org that referenced this pull request Jul 27, 2021
* feat: impl dist-tag hooks

* test: add tag assert
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants