This repository has been archived by the owner on Jun 2, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 746
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1612 +/- ##
==========================================
- Coverage 87.53% 87.27% -0.27%
==========================================
Files 97 97
Lines 4221 4228 +7
Branches 809 809
==========================================
- Hits 3695 3690 -5
- Misses 526 538 +12
Continue to review full report at Codecov.
|
fengmk2
reviewed
Jan 14, 2021
assert(envelope.version === '1.0.1'); | ||
assert(envelope.name === '@cnpmtest/dist_tag_test_module_set'); | ||
assert(envelope.type === 'package'); | ||
assert(envelope.event === 'package:dist-tag'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tag 的值也加上 assert,下面的测试用例也是。
fengmk2
approved these changes
Jan 14, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
其他没有问题了,可以随时合并。
liuweifeng
pushed a commit
to liuweifeng/cnpmjs.org
that referenced
this pull request
Jul 27, 2021
* feat: impl dist-tag hooks * test: add tag assert
This was referenced Jan 28, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.