f

cnpm · May 18, 2024 · 344bf2d · 344bf2d
1 parent e23080b
commit 344bf2d
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 4 deletions.
diff --git a/app/core/event/SyncPackageVersionFile.ts b/app/core/event/SyncPackageVersionFile.ts
@@ -1,6 +1,6 @@
 import { Event, Inject } from '@eggjs/tegg';
 import {
-  EggAppConfig,
+  EggAppConfig, EggLogger,
 } from 'egg';
 import { ForbiddenError } from 'egg-errors';
 import { PACKAGE_VERSION_ADDED, PACKAGE_TAG_ADDED, PACKAGE_TAG_CHANGED } from './index';
@@ -12,6 +12,8 @@ class SyncPackageVersionFileEvent {
   @Inject()
   protected readonly config: EggAppConfig;
   @Inject()
+  protected readonly logger: EggLogger;
+  @Inject()
   private readonly packageManagerService: PackageManagerService;
   @Inject()
   private readonly packageVersionFileService: PackageVersionFileService;
@@ -30,7 +32,9 @@ class SyncPackageVersionFileEvent {
       await this.packageVersionFileService.syncPackageVersionFiles(packageVersion);
     } catch (err) {
       if (err instanceof ForbiddenError) {
-        // ignore it
+        this.logger.info('[SyncPackageVersionFileEvent.syncPackageVersionFile] ignore sync files, cause: %s',
+          err.message,
+        );
         return;
       }
       throw err;

diff --git a/app/core/service/PackageVersionFileService.ts b/app/core/service/PackageVersionFileService.ts
@@ -79,13 +79,14 @@ export class PackageVersionFileService extends AbstractService {
     }
   }
 
-  async updateUnpkgWhiteList() {
+  async #updateUnpkgWhiteList() {
     if (!this.config.cnpmcore.enableSyncUnpkgFilesWhiteList) return;
     const whiteListScope = '';
     const whiteListPackageName = 'unpkg-white-list';
     const whiteListPackageVersion = await this.packageVersionRepository.findVersionByTag(
       whiteListScope, whiteListPackageName, 'latest');
     if (!whiteListPackageVersion) return;
+    // same version, skip update for performance
     if (this.#unpkgWhiteListCurrentVersion === whiteListPackageVersion) return;
 
     // update the new version white list
@@ -104,7 +105,7 @@ export class PackageVersionFileService extends AbstractService {
 
   async #checkPackageVersionInUnpkgWhiteList(pkgScope: string, pkgName: string, pkgVersion: string) {
     if (!this.config.cnpmcore.enableSyncUnpkgFilesWhiteList) return;
-    await this.updateUnpkgWhiteList();
+    await this.#updateUnpkgWhiteList();
 
     // check allow scopes
     if (this.#unpkgWhiteListAllowScopes.includes(pkgScope)) return;