Fixing console warnings and errors

cnocon · Dec 28, 2020 · 8c0d39d · 8c0d39d
1 parent e43aaca
commit 8c0d39d
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 8 deletions.
diff --git a/src/App.js b/src/App.js
@@ -1,5 +1,5 @@
 import React from 'react';
-import { BrowserRouter as Router, Switch, Route, Link } from "react-router-dom";
+import { BrowserRouter as Router, Switch, Route } from "react-router-dom";
 import NotFound from './components/NotFound/NotFound';
 import Deck from './components/Deck/Deck';
 import Theme from './Theme';
@@ -36,7 +36,7 @@ export const App = () => {
                 </Styled.Content>
               </Router>
               <Styled.AppFooter>
-                <p><b>Copyright &copy;2020</b>&nbsp;&nbsp;|&nbsp;&nbsp;<a href="https://cristin.io" target="_blank" rel="noreferrer">CRISTIN.IO</a></p>
+                <p><b>Copyright &copy;2020</b>&nbsp;&nbsp;|&nbsp;&nbsp;<a href="https://cristin.io" target="_blank" rel="noopener noreferrer">CRISTIN.IO</a></p>
               </Styled.AppFooter>
             </Styled.MainWrapper>
           </Styled.Layout>

diff --git a/src/components/Deck/Deck.jsx b/src/components/Deck/Deck.jsx
@@ -38,15 +38,16 @@ const Deck = () => {
     }
   }
 
-  useEffect(() => {
-    if (!CardsContext.cards.length > 0) {
+  const loadContent = () => {
+    if (CardsContext.cards.length === 0) {
       CardsContext.getCards();
-    }
-
-    if (!CardsContext.categories.length > 0) {
       CardsContext.getCategories();
     }
-  }, []);
+  }
+
+  useEffect(() => {
+    loadContent();
+  });
 
   return (
     <Styled.Deck>