Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Assessment criteria & template update #77

Merged
merged 3 commits into from
Oct 28, 2021
Merged

Assessment criteria & template update #77

merged 3 commits into from
Oct 28, 2021

Conversation

chalin
Copy link
Collaborator

@chalin chalin commented Oct 28, 2021 •
edited
Loading

@chalin chalin added the enhancement New feature or request label Oct 28, 2021
@chalin chalin requested a review from celestehorgan October 28, 2021 18:56
@chalin
Copy link
Collaborator Author

chalin commented Oct 28, 2021

This PR is best reviewed while ignoring whitespace changes.

celestehorgan
celestehorgan reviewed Oct 28, 2021
View reviewed changes
Copy link
Contributor

@celestehorgan celestehorgan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small comment but otherwise: 🔥 🔥 🔥 awesome!!!!

assessments/criteria.md Outdated Show resolved Hide resolved
assessments/criteria.md Show resolved Hide resolved
celestehorgan
celestehorgan approved these changes Oct 28, 2021
View reviewed changes
Copy link
Contributor

@celestehorgan celestehorgan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@celestehorgan celestehorgan merged commit 319b638 into cncf:main Oct 28, 2021
@chalin chalin deleted the chalin-assessment-criteria-update-2021-10-28 branch November 3, 2021 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@celestehorgan celestehorgan celestehorgan approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
2 participants
@chalin @celestehorgan