Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change WG Comms references to WG Sustainability Advocacy and update old translations (#502) #576

Merged
merged 1 commit into from
Nov 11, 2024

Conversation

vallss
Copy link
Contributor

@vallss vallss commented Nov 10, 2024

This PR updates all the references of WG Comms to WG Sustainability Advocacy as part of the rebranding of the WG. In particular:

  • change the folder name under working-groups and its references in the about/working-groups page
  • change Slack channel name on every homepage, including translations

Copy link

netlify bot commented Nov 10, 2024

Deploy Preview for tag-env-sustainability ready!

Name Link
🔨 Latest commit 656bdc8
🔍 Latest deploy log https://app.netlify.com/sites/tag-env-sustainability/deploys/67310028d55b130009da3c1b
😎 Deploy Preview https://deploy-preview-576--tag-env-sustainability.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@vallss
Copy link
Contributor Author

vallss commented Nov 10, 2024

@guidemetothemoon Not 100% sure whether the following errors will fix themselves after merging because we're actually changing the urls in this PR and obviously they now point to the not-yet-updated-links

ERROR: 3 dead links found! [✖] https://github.com/cncf/tag-env-sustainability/tree/main/working-groups/sustainability-advocacy → Status: [404](https://github.com/cncf/tag-env-sustainability/actions/runs/11767656936/job/32776584823?pr=576#step:9:406) [✖] https://github.com/cncf/tag-env-sustainability/tree/main/working-groups/sustainability-advocacy/charter.md → Status: 404 [✖] https://github.com/cncf/tag-env-sustainability/blob/main/working-groups/sustainability-advocacy/README.md#meetings-and-contact → Status: 404

@guidemetothemoon
Copy link
Contributor

@vallss the check is running towards main branch so if links are updated as part of the PR the check may fail. But it will be OK once the PR is merged 😊

Copy link
Contributor

@guidemetothemoon guidemetothemoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@guidemetothemoon guidemetothemoon merged commit 8bf97be into cncf:main Nov 11, 2024
5 of 6 checks passed
@vallss
Copy link
Contributor Author

vallss commented Nov 11, 2024

@guidemetothemoon great, thanks! 💚

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants