-
Notifications
You must be signed in to change notification settings - Fork 555
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix configuration for branch protection #296
Conversation
✔️ Deploy Preview for cncfglossary ready! 🔨 Explore the source changes: 69f6bcc 🔍 Inspect the deploy log: https://app.netlify.com/sites/cncfglossary/deploys/61ddb90fe1c1390008bb51ba 😎 Browse the preview: https://deploy-preview-296--cncfglossary.netlify.app |
@JasonMorgan PTAL this PR :) |
Hey @seokho-son it looks good with the exception that @murillodigital is moving to emeritus status and shouldn't be included in maintainers/owners. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we drop murillodigital from maintainers?
@JasonMorgan Thanks ! |
The current settings for branch protection seems not work properly.
(I think some settings of https://github.com/apps/settings are not stable yet)
This PR updates
.github/settings.yml
andCODEOWNERS
to fix configuration on branch protection.I also suggest following configuration for permission.
dev-ko
)main
branchI'v tested
https://github.com/apps/settings
with a similar configuration in another organization :)I hope this PR resolves all :)
Please note that
admin
to check this setting byhttps://github.com/apps/settings
works properly. (we can check this fromsetting
tap)