Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User Acceptance Testing for pga #26

Open
RobertKielty opened this issue Oct 10, 2022 · 8 comments
Open

User Acceptance Testing for pga #26

RobertKielty opened this issue Oct 10, 2022 · 8 comments
Labels
area/pga documentation Improvements or additions to documentation

Comments

@RobertKielty
Copy link
Contributor

List out some acceptance criteria segmented by plugin so as to report on what plugins work when started from prow-github-actions

@RobertKielty RobertKielty added the documentation Improvements or additions to documentation label Oct 10, 2022
@RobertKielty
Copy link
Contributor Author

/label area/pga

@github-actions
Copy link

@RobertKielty: The label(s) /label area/pga cannot be applied. These labels are supported: api-review, tide/merge-method-merge, tide/merge-method-rebase, tide/merge-method-squash, team/katacoda, refactor

In response to this:

/label area/pga

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@RobertKielty
Copy link
Contributor Author

@Riaankl from our meeting let's note the location of the config for the label plugin

It is here ...
https://github.com/cncf-infra/prow-github-action/blob/27150/prow/cmd/pga/kodata/plugins.yaml#L37

and is currently configured as follows

label:
  additional_labels:
    # This label is used by the API review process
    # https://git.k8s.io/community/sig-architecture/api-review-process.md#mechanics
    - api-review
    # These labels are used to make Tide merge with a non-default merge method
    - tide/merge-method-merge
    - tide/merge-method-rebase
    - tide/merge-method-squash
    # This label, for k/website, identifies issues relevant to https://katacoda.com/
    - team/katacoda
    # This label, for k/website, identifies PRs with large refactoring changes
    - refactor

hence the messaging above in the prev comment by the github-actions bot

@hh
Copy link
Contributor

hh commented Oct 10, 2022

/label api-review

@github-actions
Copy link

@hh: The label(s) api-review cannot be applied, because the repository doesn't have them.

In response to this:

/label api-review

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@hh
Copy link
Contributor

hh commented Oct 10, 2022

We'll need to create a folder for syncing labels: https://github.com/kubernetes/test-infra/tree/master/label_sync#label_sync

Let's look into creating a label_sync GitHub action job that get's trigged when the labels.yaml changes.

@RobertKielty
Copy link
Contributor Author

@hh Thank you for that can you add the above ^^ as a new Issue and label it as an enhancement please so it does not get lost.

@RobertKielty
Copy link
Contributor Author

/assign @RobertKielty @Riaankl

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/pga documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

2 participants