Improve type after PR elastic#82125

cnasikas · Nov 3, 2020 · bf2789f · bf2789f
1 parent 484593c
commit bf2789f
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 6 deletions.
diff --git a/x-pack/plugins/case/server/connectors/case/types.ts b/x-pack/plugins/case/server/connectors/case/types.ts
@@ -35,8 +35,6 @@ export type CaseActionType = ActionType<
   CaseExecutorResponse | {}
 >;
 
-export type CaseActionTypeWithoutExecutor = ActionType<CaseConfiguration, {}, CaseExecutorParams>;
-
 export type CaseActionTypeExecutorOptions = ActionTypeExecutorOptions<
   CaseConfiguration,
   {},

diff --git a/x-pack/plugins/case/server/connectors/index.ts b/x-pack/plugins/case/server/connectors/index.ts
@@ -19,7 +19,6 @@ import {
 } from '../services';
 
 import { getActionType as getCaseConnector } from './case';
-import { CaseActionTypeWithoutExecutor } from './case/types';
 
 export interface GetActionTypeParams {
   logger: Logger;
@@ -32,9 +31,10 @@ export interface RegisterConnectorsArgs extends GetActionTypeParams {
   actionsRegisterType<
     Config extends ActionTypeConfig = ActionTypeConfig,
     Secrets extends ActionTypeSecrets = ActionTypeSecrets,
-    Params extends ActionTypeParams = ActionTypeParams
+    Params extends ActionTypeParams = ActionTypeParams,
+    ExecutorResultData = void
   >(
-    actionType: ActionType<Config, Secrets, Params>
+    actionType: ActionType<Config, Secrets, Params, ExecutorResultData>
   ): void;
 }
 
@@ -51,6 +51,6 @@ export const registerConnectors = ({
       caseService,
       caseConfigureService,
       userActionService,
-    }) as CaseActionTypeWithoutExecutor
+    })
   );
 };