This repository has been archived by the owner on May 3, 2022. It is now read-only.
ref(*): remove the loader pkg; use cnab-go's #832
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmd/duffle/export.go
Outdated
| "github.com/deislabs/duffle/pkg/packager" | ||
|
|
||
| "github.com/deislabs/cnab-go/bundle/loader" |
There was a problem hiding this comment.
nit: The modified imports are not well grouped, here and in the following files
glyn
approved these changes
Aug 13, 2019
vdice
force-pushed
the
ref/rm-loader
branch
2 times, most recently
from
eebe661
to
08b8339
Compare
vdice
changed the title
jeremyrickard
approved these changes
Aug 14, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes the
loaderpkg per cnabio/cnab-go#98TODO:
vendormod with appropriate cnab-go bump (didn't go the route of updating Gopkg.toml w/ my source/branch b/c it's based on latest cnab-go, which includes many changes; see Sync Duffle with latest changes from cnab-go #827)