Add original image field to base bundle #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bundle/bundle.go
Outdated
| MediaType string `json:"mediaType,omitempty" mapstructure:"mediaType"` | ||
| ImageType string `json:"imageType" mapstructure:"imageType"` | ||
| Image string `json:"image" mapstructure:"image"` | ||
| OriginalImage string `json:"originalImage" mapstructure:"originalImage"` |
There was a problem hiding this comment.
As far as I can remember originalImage is OPTIONAL, so I think it should be annotated with omitempty:
OriginalImage string `json:"originalImage,omitempty" mapstructure:"originalImage"`There was a problem hiding this comment.
Correct. Fixed (including a test).
glyn
force-pushed
the
add-original-image-name
branch
from
1cd2642
to
d54f80b
Compare
radu-matei
approved these changes
Apr 16, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See cnabio/cnab-spec#134