Fix dynamic layer identifies for sublayer id 0 #706
Conversation
…0 add formatter example
viewer/js/config/identify.js
Outdated
| @@ -34,6 +34,21 @@ define([ | |||
| // for details on pop-up definition see: https://developers.arcgis.com/javascript/jshelp/intro_popuptemplate.html | |||
|
|
|||
| identifies: { | |||
| population: { | |||
There was a problem hiding this comment.
Looking towards the future, I would like to avoid using services from sampleserver1 (and 2, 3, and 4). These older servers at version 10.0 are problematic for use with version 4.x (specifically when using 3D maps). This applies to the existing Louisville Public Safety service and SF 311 services as well. Public Safety Service is where the problems with 4.x surfaced.
For now, how about we remove or replace the Population service in this PR? (replace from sampleserver6?) Then we can replace the other out-of-date services in a separate PR. Thoughts?
viewer/js/config/identify.js
Outdated
| visible: true, | ||
| fieldName: 'POP', | ||
| label: 'Population', | ||
| formatter: commafy |
There was a problem hiding this comment.
Wouldn't dojo's number.format be a better practice to promote - automatically handling differences based on locale?
|
@roemhildtg I have tested the change to Identify and verified this works. I made a few additional changes. Please review and comment. thanks. |
|
Yes, this looks good to me. |
Description
Fix bug #675 with better check for valid layer id
Checklist
grunt lintproduces no error messages