-
-
Notifications
You must be signed in to change notification settings - Fork 278
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add nls support in config files, add pt-pt translation #572
Conversation
uniformize keys names to camelCase.
and drop meetupHometowns layer reference, it isn't being used anymore
@iled travis found some eslint errors. indentation in some of pt-pt resource files and a 3 missing semicolons 😉 in config files. the errors are spelled out in the log here. If you run the @DavidSpriggs thoughts? |
Fixed eslint errors. Reverted renaming Esri basemaps. |
@iled all looks good to me. Let's see if @DavidSpriggs has any comments about the approach I recommended for i18n in the config files. |
Looks good. Pulling in the i18n works for now. If we ever want pure Json config files we will have to rethink this approach. This occurs in other places too. |
Thanks @iled ! |
These commits add a complete Portuguese (pt-pt) translation to CMV, including:
viewer.js
and the other config files didn't have support for nls, so it was also added. All input text included in each config file is stored innls/main.js
. E.g.,Other changes included:
config/identify.js
I started this translation by forking a repo by @carrbrpoa.