updated basemaps widget combining agol and custom basemaps #522
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maintained support for existing agol and custom configurations removed BasemapGallery widget custom basemaps allowing for more custom map types
Basemap and BasemapLayer dijits no longer needed for custom basemaps some of the examples required v 3.16 or higher of the ESRI JavaScript API
|
As I experiment with this further, it appears that ESRI has limited the I will keep this PR open for any additional discussion and potential revision but it should not be committed as is. |
Custom basemaps are also supported in agol mode for those types
of basemaps which are supported by `esri/basemaps`
Added additional examples of custom basemaps using WebMapTiled layers
|
I have restored the @DavidSpriggs Ready for review and merge. |
|
@tmcgee Merge prior into this PR. |
# Conflicts: # viewer/js/config/basemaps.js
|
@DavidSpriggs done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.