updates #460
updates #460
Conversation
| config = config || {}; | ||
| var ip = new ImageParameters(); | ||
| //image parameters for dynamic services, set to png32 for higher quality exports | ||
| ip.format = 'png32'; |
There was a problem hiding this comment.
I think this should be passed in as a parameter to the function for each layer instead of being hard-coded. Or at least mixed in so it can be overridden.
There was a problem hiding this comment.
This just defaults to 'png32'. If config has {format: 'png8'} it will get overridden.
|
I think this is good. I never liked having so much code baked into the html template. I don't think this would cause any backward compatibility issues so this could be released ahead of an eventual 2.0 release. For my own apps, I moved the buildImageParameters function into a utility module so it could be used elsewhere but I think including it in viewer.js is a good example for those less familiar with CMV. We may want to make a note to re-visit this function with the 4.0 API. I believe in 4.0 all properties can be set as constructor arguments which could make this function a bit simpler, maybe even negate the need for it. I think we should go ahead with these changes. |
Just a few housekeeping items; and fixes #457.