Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mobile Popup #455

Closed
gregoryaroberts1 opened this issue Aug 28, 2015 · 10 comments
Closed

Mobile Popup #455

gregoryaroberts1 opened this issue Aug 28, 2015 · 10 comments
Assignees
Labels
Milestone

Comments

@gregoryaroberts1
Copy link

Hello, I am experiencing an issue when testing the CMV with a mobile device. PopupMobile only seems to work with the identify template(s) in the identify.js file located in the config folder. With an identify template (like the reverseGeocodeTemplate in the Geocoder widget), the mobile popup window only displays the title and no content.

image

@tmcgee
Copy link
Member

tmcgee commented Aug 28, 2015

@gregoryaroberts1 Are you using your own modified reverseGeocodeTemplate or are you using the default one? If it is modified, can you please post it here in a comment.

@gregoryaroberts1
Copy link
Author

I initially discovered this while developing a customized version of the Geocoder widget but I tested the demo site with a mobile device and am experiencing the same issue.

@tmcgee tmcgee added the bug label Aug 28, 2015
@tmcgee tmcgee added this to the v1.3.4 milestone Aug 28, 2015
@tmcgee tmcgee self-assigned this Aug 28, 2015
@tmcgee
Copy link
Member

tmcgee commented Aug 28, 2015

@gregoryaroberts1 yep. I have also verified this behavior with the default reverseGeocodeTemplate in the demo site. Looks like a bug to me. I've assigned it to myself for investigation and any fix to be included in the next cmv release.

@gregoryaroberts1
Copy link
Author

Great! Thanks for looking into this.

@tmcgee tmcgee modified the milestones: v1.3.4, v1.4.0 Nov 23, 2015
@carrbrpoa
Copy link

I only manage to show something in mobile running reverse geocoder when I do

if (has('phone')) {
    this.map.infoWindow.setFeatures([graphic]);
}

in the end of Geocoder's reverseGeocodeComplete function.

@tmcgee
Copy link
Member

tmcgee commented Apr 1, 2016

@carrbrpoa Thanks for posting your findings. I haven't looked at the code but might that work without the IF statement for all browsers?

@carrbrpoa
Copy link

Actually it works! Just tested here. No IF needed.
But the results are different (with or without the IF). See:

Desktop/tablet:
other

Phone (2 steps needed to see the data):
phone

@tmcgee
Copy link
Member

tmcgee commented Apr 1, 2016

Great to know!.

That two step process is the default way the ESRI mobile popup works.

@tmcgee
Copy link
Member

tmcgee commented Apr 2, 2016

Capturing a few items related to this for further discussion:

  1. The ReveseGeocoding discussed above is part of the CMV Geocoder widget. The ESRI Geocoder widget has been deprecated and replaced a few versions back with a newer Search widget. The next release of CMV (develop branch) will support the Search widget. As a result we are removing support for CMV GeoCoder widget.
  2. Reverse Geocoding uses the method ._task.locationToAddress of the Geocoder widget. _task is not documented in the API. There likely is an equivalent object in the Search widget but we should move away from this. I propose we create a new ReverseGeocoder widget that would use esri/tasks/locator which is documented and supported.
  3. The right-click menu no longer works with v 3.15 and v 3.16 of the ESRI API. This is because ESRI changed the CSS class we use for a selector. In v 3.14 (and below), the selector was .layersDiv. In v 3.15 and v 3.16, the selector is now .esriMapLayers. This will be updated in the develop branch for the upcoming cmv release.

notifying @DavidSpriggs for opportunity to comment.

tmcgee added a commit that referenced this issue Apr 3, 2016
DavidSpriggs added a commit that referenced this issue Apr 3, 2016
Fixes mobile popup for reverse geocoding identified in issue #455
@tmcgee
Copy link
Member

tmcgee commented Apr 3, 2016

Original issue with Geocoder widget fixed in PR #531. Right click menu mentioned in last comment resolved in PR #530. Discussion on possible new ReverserGeocoder widget to be continued...

@tmcgee tmcgee closed this as completed Apr 3, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants