-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: produce metadata in optimizer output #83
Conversation
bf54cb9
to
0b316cb
Compare
637a7f2
to
fccbae2
Compare
optd-core/src/cascades/optimizer.rs
Outdated
} | ||
|
||
/// Get the group binding. | ||
pub fn step_get_optimize_rel(&self, group_id: GroupId) -> Result<RelNodeRef<T>> { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we still need this? Maintaining two versions of step_get_optimizer_rel_[with_meta]
seems error-prone.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yea maybe I will add an Option<Meta>
and keep one copy.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When will this meta be none though?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are right, I think I was mixing this one up with memo.get_best_group_binding()
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This feature is great! IIUC it also enables displaying logical properties or cost in explain stmt.
f6c4dbd
to
33d9214
Compare
Signed-off-by: Yuchen Liang <[email protected]>
Signed-off-by: Yuchen Liang <[email protected]>
Signed-off-by: Yuchen Liang <[email protected]>
Signed-off-by: Yuchen Liang <[email protected]>
Signed-off-by: Yuchen Liang <[email protected]>
Signed-off-by: Yuchen Liang <[email protected]>
Signed-off-by: Yuchen Liang <[email protected]>
b3d4fe5
to
f268eb1
Compare
Signed-off-by: Yuchen Liang <[email protected]>
4ccfc92
to
20fa55d
Compare
Signed-off-by: Yuchen Liang <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Closes #65. This PR produces metadata in optimizer output. Currently, the only metadata kept is the group id. The group id information has the following benefits:
optd-core
.explain
#89Looking forward to feedbacks!
In the example below, we produce the same plan as before when adaptiveness is enabled.