Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

Add PYTHONPATH to tests in CMake. Ignore cmake-build-relwithdebinfo. Verbose self-driving tests. #1611

Merged
merged 5 commits into from
Jun 10, 2021

Conversation

lmwnshn
Copy link
Contributor

@lmwnshn lmwnshn commented Jun 9, 2021

Heading

Add PYTHONPATH to tests in CMake. Ignore cmake-build-relwithdebinfo.

Description

Remaining tasks

Going to see whether it produces a reasonable amount of output in CI for the self-driving tests.

@lmwnshn lmwnshn added ready-for-review This PR passes all checks and is ready to be reviewed. Mark PRs with this. ready-for-ci Indicate that this build should be run through CI. labels Jun 9, 2021
@lmwnshn lmwnshn self-assigned this Jun 9, 2021
@lmwnshn lmwnshn changed the title Add PYTHONPATH to tests in CMake. Ignore cmake-build-relwithdebinfo. Add PYTHONPATH to tests in CMake. Ignore cmake-build-relwithdebinfo. Verbose self-driving tests. Jun 9, 2021
@noisepage-checks
Copy link

Minor Decrease in Performance

Be warned: this PR may have decreased the throughput of the system slightly.

tps (%change) benchmark_type wal_device details
3.0% tpcc RAM disk
Detailsmaster tps=22447.93, commit tps=23120.58, query_mode=extended, benchmark_type=tpcc, scale_factor=32.0000, terminals=32, client_time=60, weights={'Payment': 43, 'Delivery': 4, 'NewOrder': 45, 'StockLevel': 4, 'OrderStatus': 4}, wal_device=RAM disk, max_connection_threads=32
-1.02% tpcc None
Detailsmaster tps=29657.01, commit tps=29353.84, query_mode=extended, benchmark_type=tpcc, scale_factor=32.0000, terminals=32, client_time=60, weights={'Payment': 43, 'Delivery': 4, 'NewOrder': 45, 'StockLevel': 4, 'OrderStatus': 4}, wal_device=None, max_connection_threads=32
-1.12% tpcc HDD
Detailsmaster tps=21947.81, commit tps=21701.46, query_mode=extended, benchmark_type=tpcc, scale_factor=32.0000, terminals=32, client_time=60, weights={'Payment': 43, 'Delivery': 4, 'NewOrder': 45, 'StockLevel': 4, 'OrderStatus': 4}, wal_device=HDD, max_connection_threads=32
8.89% tatp RAM disk
Detailsmaster tps=6506.9, commit tps=7085.66, query_mode=extended, benchmark_type=tatp, scale_factor=1.0000, terminals=16, client_time=60, weights={'GetAccessData': 35, 'UpdateLocation': 14, 'GetNewDestination': 10, 'GetSubscriberData': 35, 'DeleteCallForwarding': 2, 'InsertCallForwarding': 2, 'UpdateSubscriberData': 2}, wal_device=RAM disk, max_connection_threads=32
0.52% tatp None
Detailsmaster tps=7498.08, commit tps=7536.86, query_mode=extended, benchmark_type=tatp, scale_factor=1.0000, terminals=16, client_time=60, weights={'GetAccessData': 35, 'UpdateLocation': 14, 'GetNewDestination': 10, 'GetSubscriberData': 35, 'DeleteCallForwarding': 2, 'InsertCallForwarding': 2, 'UpdateSubscriberData': 2}, wal_device=None, max_connection_threads=32
5.86% tatp HDD
Detailsmaster tps=6535.22, commit tps=6918.21, query_mode=extended, benchmark_type=tatp, scale_factor=1.0000, terminals=16, client_time=60, weights={'GetAccessData': 35, 'UpdateLocation': 14, 'GetNewDestination': 10, 'GetSubscriberData': 35, 'DeleteCallForwarding': 2, 'InsertCallForwarding': 2, 'UpdateSubscriberData': 2}, wal_device=HDD, max_connection_threads=32

@codecov
Copy link

codecov bot commented Jun 10, 2021

Codecov Report

Merging #1611 (1e6d0e1) into master (39d598b) will decrease coverage by 69.20%.
The diff coverage is n/a.

❗ Current head 1e6d0e1 differs from pull request most recent head 708245e. Consider uploading reports for the commit 708245e to get more accurate results
Impacted file tree graph

@@             Coverage Diff             @@
##           master    #1611       +/-   ##
===========================================
- Coverage   80.73%   11.53%   -69.21%     
===========================================
  Files         751      739       -12     
  Lines       52798    51027     -1771     
===========================================
- Hits        42627     5885    -36742     
- Misses      10171    45142    +34971     
Impacted Files Coverage Δ
src/optimizer/util.cpp 0.00% <0.00%> (-100.00%) ⬇️
src/common/math_util.cpp 0.00% <0.00%> (-100.00%) ⬇️
src/task/task_runner.cpp 0.00% <0.00%> (-100.00%) ⬇️
src/task/task_manager.cpp 0.00% <0.00%> (-100.00%) ⬇️
src/execution/sema/sema.cpp 0.00% <0.00%> (-100.00%) ⬇️
src/execution/sema/scope.cpp 0.00% <0.00%> (-100.00%) ⬇️
src/include/optimizer/memo.h 0.00% <0.00%> (-100.00%) ⬇️
src/include/optimizer/rule.h 0.00% <0.00%> (-100.00%) ⬇️
src/include/optimizer/util.h 0.00% <0.00%> (-100.00%) ⬇️
src/execution/compiler/if.cpp 0.00% <0.00%> (-100.00%) ⬇️
... and 607 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 39d598b...708245e. Read the comment docs.

@lmwnshn lmwnshn merged commit 1b8a9b0 into cmu-db:master Jun 10, 2021
@lmwnshn lmwnshn deleted the 2021-06_cmake_things branch June 10, 2021 13:41
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
ready-for-ci Indicate that this build should be run through CI. ready-for-review This PR passes all checks and is ready to be reviewed. Mark PRs with this.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant