-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Materialize terror symbols #191
Materialize terror symbols #191
Commits on Dec 19, 2023
-
Fix in complex_quartic problem reported in issue root-project#6900 an…
…d add test (root-project#6908) * Fix in complex_quartic problem reported in issue root-project#6900 and add test Uncomment some different code that is used to compute the discriminat of the resolvent cubic equation used to find roots of quartic. This code seems to eprforms better. This fixes root-project#6900 Add tests for quartic equations * Update and fix links and spelling in the reference documentation of ROOT::Math::Polynomial * Increate test tolerance for fixing failure observed in i386
Configuration menu - View commit details
-
Copy full SHA for f650645 - Browse repository at this point
Copy the full SHA f650645View commit details -
[RF] Deprecate old test statistics headers
The old test statistic headers and classes should not be used anymore, since the test statistics should be created with the higher-level functions `createNLL()` and `createChi2()`. This allows us more flexibility in the implementation, and to phase out the old test statistics classes eventually.
Configuration menu - View commit details
-
Copy full SHA for 5bdcdaf - Browse repository at this point
Copy the full SHA 5bdcdafView commit details -
[RF] Move internal enums of RooResolutionModels out of public interface
This gives us more freedom when refactoring things to also support code generation with AD. Also apply other code modernizations, like less use of `TString` or delegating constructors.
Configuration menu - View commit details
-
Copy full SHA for 2a07a67 - Browse repository at this point
Copy the full SHA 2a07a67View commit details -
Configuration menu - View commit details
-
Copy full SHA for faa0b27 - Browse repository at this point
Copy the full SHA faa0b27View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9f7405e - Browse repository at this point
Copy the full SHA 9f7405eView commit details -
[cmake] Set policy CMP0116 to OLD
As done by interpreter/llvm-project/cmake/Modules/CMakePolicy.cmake, but this resolves many warnings when building with builtin_llvm=OFF (but builtin_clang=ON): ``` CMake Warning (dev) at /usr/lib64/cmake/llvm/TableGen.cmake:95 (add_custom_command): Policy CMP0116 is not set: Ninja generators transform DEPFILEs from add_custom_command(). Run "cmake --help-policy CMP0116" for policy details. Use the cmake_policy command to set the policy and suppress this warning. Call Stack (most recent call first): interpreter/llvm-project/clang/cmake/modules/AddClang.cmake:25 (tablegen) interpreter/llvm-project/clang/include/clang/AST/CMakeLists.txt:73 (clang_tablegen) This warning is for project developers. Use -Wno-dev to suppress it. ```
Configuration menu - View commit details
-
Copy full SHA for 7392b02 - Browse repository at this point
Copy the full SHA 7392b02View commit details -
On Windows, attempts to find R in the default installation paths if not found via find_program. Does the same for the R_LIBRARY variable, which may not be reported by the R executable on Windows. Adds an R_SCRIPT variable to provide the path to RScript. This is useful if the parent CMake script wants to call R non-interactively to run a script. Fixed a typo in the comments.
Configuration menu - View commit details
-
Copy full SHA for 9e64cda - Browse repository at this point
Copy the full SHA 9e64cdaView commit details -
Refactor TBranchProxy::GetReadType to fix warning
nvc++ issued a warning on the last return statement being unreachable.
Configuration menu - View commit details
-
Copy full SHA for 827b7e3 - Browse repository at this point
Copy the full SHA 827b7e3View commit details -
[core] Materialize symbols for TError variables
The variables present in TError.h are used throughout the ROOT libraries. Anytime one of these variables is requested, e.g. with a simple test such as `python -c "import ROOT; ROOT.kError"`, the interpreter will lookup the corresponding symbol. Previously, the variables were declared and defined in the header directly but were not generating any symbol since the linkage was internal. With this commit, provide external linkage to these variables so that the corresponding symbols are materialized in libCore.so. As a consequence, a huge number of extra lookups by cling is avoided.
Configuration menu - View commit details
-
Copy full SHA for f41a042 - Browse repository at this point
Copy the full SHA f41a042View commit details