[PyROOT][ROOT-10294] Reuse TEnum to get its underlying type #132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Provide also entry in release notes
Use unique_ptr<TXMLEngine> as holder
Clarifies ownership of this elements
Not really used, but keep it here for compatibility
Before TSQLFile times were used
Wrong optimization was used. Fixes https://root-forum.cern.ch/t/35782/
Make sure to Clear the list 'extrainfos' before any of its content is deleted. See https://root-forum.cern.ch/t/tfile-makeproject-severely-broken-in-root-6-08-06-6-18-00/34924
When using cppyy from ROOT, many symbols coming from ROOT libraries can be found when running dir(cppyy.gbl). In order to obtain such list of symbols, cppyy scans the rootmap files. This allows tab-completion before classes are even loaded, let alone bound. This change sets a variable so that the symbols in Core, IO, Thread and MathCore are not cleaned up by cppyy.
This is the default value in the current PyROOT, which has changed in Cppyy.
RemoveAt relies on Remove, which at its turn applies IsEqual to find the element it needs to remove. If there are two elements in the list that are equal, Remove just removes the first it finds, not the one with the specified index.
Now experimental PyROOT, as the old PyROOT, has kMemoryHeuristics as default memory policy for arguments of callables. Thus, the ownership is automatically transferred from Python to C++ for non-const pointer arguments.
This patch is to be merged into ROOT (modulo some modifications to cover cases that are still failing): https://bitbucket.org/wlav/cppyy-backend/src/master/cling/patches/using_decls.diff Without that patch, Cppyy does not automatically add to a class the method overloads that come from a 'using' statement. In the meantime, this commit adds a pythonisation that is needed for RooDataHist to see the overloads it is using from RooAbsData. Once the more general solution is implemented in the bindings, this pythonisation will be removed.
As pointed out in ROOT-10294, when using the CMSSW environment, the lookup of an enum constant in the list of attributes of the namespace does not succeed. This commit passes on the TEnum obtained when creating the namespace proxy to the addition of the enum constants as properties of the namespace, so that the underlying type of the enum can be taken from the TEnum, and therefore we avoid the lookup in the list of attributes of the namespace.
|
please test for CMSSW_11_0_ROOT6_X |
|
A new Pull Request was created by @smuzaffar (Malik Shahzad Muzaffar) for branch cms/master/f579155. @cmsbuild, @smuzaffar, @mrodozov can you please review it and eventually sign? Thanks. |
|
The tests are being triggered in jenkins. |
|
closing it, this has already been merged in to root master and cms-sw/cmsdist#5186 includes it. |
|
-1 Tested at: 1c0341f You can see the results of the tests here: I found follow errors while testing this PR Failed tests: Build
I found compilation error when building: >> Compiling /build/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_0_ROOT6_X_2019-08-29-2300/src/Utilities/StaticAnalyzers/src/ClassDumper.cpp
>> Compiling /build/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_0_ROOT6_X_2019-08-29-2300/src/Utilities/StaticAnalyzers/src/ThrUnsafeFCallChecker.cpp
>> Compiling /build/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_0_ROOT6_X_2019-08-29-2300/src/Utilities/StaticAnalyzers/src/ClangCmsCheckerPluginRegister.cpp
>> Compiling /build/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_0_ROOT6_X_2019-08-29-2300/src/Utilities/StaticAnalyzers/src/CmsSupport.cpp
>> Compiling /build/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_0_ROOT6_X_2019-08-29-2300/src/Utilities/StaticAnalyzers/src/StaticLocalChecker.cpp
/build/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_0_ROOT6_X_2019-08-29-2300/src/Utilities/StaticAnalyzers/src/ClangCmsCheckerPluginRegister.cpp:27:10: fatal error: clang/StaticAnalyzer/Core/CheckerRegistry.h: No such file or directory
#include
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
compilation terminated.
>> Compiling /build/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_0_ROOT6_X_2019-08-29-2300/src/Utilities/StaticAnalyzers/src/CatchAll.cpp
>> Compiling /build/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_0_ROOT6_X_2019-08-29-2300/src/Utilities/StaticAnalyzers/src/GlobalStaticChecker.cpp
|
|
Comparison not run due to Build errors (RelVals and Igprof tests were also skipped) |
cmsbuild
added
comparison-notrun
tests-rejected
and removed
comparison-pending
tests-started
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.