Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DQM-GENERATORS] [Clang]Cleanup clang-analyzer warnings #46228

Merged
merged 1 commit into from
Oct 7, 2024
Merged

[DQM-GENERATORS] [Clang]Cleanup clang-analyzer warnings #46228

merged 1 commit into from
Oct 7, 2024
+0 −1

Conversation

smuzaffar
Copy link
Contributor

@cmsbuild cmsbuild added this to the CMSSW_14_2_X milestone Oct 3, 2024
@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 3, 2024 •
edited
Loading

cms-bot internal usage

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 3, 2024

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46228/42040

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 3, 2024

A new Pull Request was created by @smuzaffar for master.

It involves the following packages:

  • Validation/EventGenerator (dqm, generators)

@antoniovagnerini, @bbilin, @cmsbuild, @lviliani, @menglu21, @mkirsano, @nothingface0, @rvenditti, @syuvivida, @tjavaid can you please review it and eventually sign? Thanks.
@missirol this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

smuzaffar
smuzaffar commented Oct 3, 2024
View reviewed changes
Validation/EventGenerator/plugins/MBUEandQCDValidation.cc
@@ -827,7 +827,6 @@ void MBUEandQCDValidation::analyze(const edm::Event& iEvent, const edm::EventSet
}
}
nCha->Fill(nChaTra, weight);
binW = dNchdSpt->getTH1()->GetBinWidth(1);
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this seems like a dead code.

@smuzaffar
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 3, 2024

+1

Size: This PR adds an extra 24KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6cc4eb/41935/summary.html
COMMIT: 448bc08
CMSSW: CMSSW_14_2_X_2024-10-03-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/46228/41935/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

@antoniovagnerini
Copy link

+1

@smuzaffar
Copy link
Contributor Author

@bbilin, @lviliani, @menglu21, @mkirsano can you please review this ?

@lviliani
Copy link
Contributor

lviliani commented Oct 7, 2024

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 7, 2024

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

@mandrenguyen
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit edd96bd into cms-sw:master Oct 7, 2024
11 checks passed
@cmsbuild cmsbuild mentioned this pull request Oct 7, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
code-checks-approved dqm-approved fully-signed generators-approved orp-approved tests-approved
Projects
None yet
Milestone
CMSSW_14_2_X
Development

Successfully merging this pull request may close these issues.
5 participants
@smuzaffar @cmsbuild @antoniovagnerini @lviliani @mandrenguyen