Option to print periodically from SimpleMemoryCheck #46161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added option 'printEachSample'.
|
cms-bot internal usage |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46161/41958 |
|
please test |
|
A new Pull Request was created by @Dr15Jones for master. It involves the following packages:
@Dr15Jones, @cmsbuild, @makortel, @smuzaffar can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
-1 Failed Tests: UnitTests RelVals RelVals-INPUT The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
You can see more details here: Unit TestsI found 7 errors in the following unit tests: ---> test testTauEmbeddingWorkflow2016postVFP had ERRORS ---> test testTauEmbeddingWorkflow2016preVFP had ERRORS ---> test testTauEmbeddingWorkflow2018 had ERRORS and more ... RelValsExpand to see more relval errors ...RelVals-INPUT
Expand to see more relval errors ...
|
|
please test The previous failures look like a failure of our infrastructure as no FileInPath functioned. |
|
+1 Size: This PR adds an extra 12KB to repository Comparison SummarySummary:
|
|
Comparison differences are related to #39803 |
|
+core |
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @rappoccio, @antoniovilela, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2) |
|
+1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description:
Added option 'printEachSample'.
PR validation:
Compiles. Tested manually.