Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HCAL-DQM] New plot BadQualityEvents vs all LS and changes of alarm threshold for CapID and BadQEvents for CMSSW_14_1_X #46157

Merged
merged 2 commits into from
Oct 9, 2024

Conversation

denizsun
Copy link

PR description:

  • A new plot BadQualityEvents vs all LS is added,
  • Changes of error and warning alarm thresholds from 1 to 0.994 for both CapID and BadQEvents

PR validation:

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 30, 2024

A new Pull Request was created by @denizsun for CMSSW_14_1_X.

It involves the following packages:

  • DQM/HcalTasks (dqm)

@antoniovagnerini, @cmsbuild, @nothingface0, @rvenditti, @syuvivida, @tjavaid can you please review it and eventually sign? Thanks.
@DryRun, @abdoulline, @bsunanda, @salimcerci this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 30, 2024

cms-bot internal usage

@abdoulline
Copy link

abdoulline commented Oct 1, 2024

@denizsun
Shouldn't it be first submitted to the master branch (14_2_X),
and (then, or even in parallel, to save time) backported to 14_1_X ?

@denizsun
Copy link
Author

denizsun commented Oct 1, 2024

@denizsun Shouldn't it be first submitted to the master branch (14_2_X), and (then, or even in parallel, to save time) backported to 14_1_X ?

@abdoulline

We contacted to Dimitri and he wrote to create 3 PRs for CMSSW 14_2_X , 14_0_15_patch1 and 14_1_X. Since we started first with 14_1_X, we will create another PRs for the other two cmssw versions. We are working on that and these two will be ready today.

@antoniovagnerini
Copy link

backport of #46173

@antoniovagnerini
Copy link

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 4, 2024

+1

Size: This PR adds an extra 12KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-adcdfb/41958/summary.html
COMMIT: e1b7c3b
CMSSW: CMSSW_14_1_X_2024-10-03-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/46157/41958/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 59 differences found in the comparisons
  • DQMHistoTests: Total files compared: 44
  • DQMHistoTests: Total histograms compared: 3331166
  • DQMHistoTests: Total failures: 4139
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3327007
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 43 files compared)
  • Checked 191 log files, 161 edm output root files, 44 DQM output files
  • TriggerResults: no differences found

@antoniovagnerini
Copy link

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 7, 2024

This pull request is fully signed and it will be integrated in one of the next CMSSW_14_1_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_14_2_X is complete. This pull request will now be reviewed by the release team before it's merged. @rappoccio, @mandrenguyen, @antoniovilela, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

@mandrenguyen
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 81e75c1 into cms-sw:CMSSW_14_1_X Oct 9, 2024
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants