-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[14.1.X] migrate calotowers creation code to use EcalPFRecHitThresholds
#46125
[14.1.X] migrate calotowers creation code to use EcalPFRecHitThresholds
#46125
Conversation
A new Pull Request was created by @mmusich for CMSSW_14_1_X. It involves the following packages:
@cmsbuild, @jfernan2, @mandrenguyen can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
cms-bot internal usage |
@cmsbuild, please test |
type hlt-integration |
+1 Size: This PR adds an extra 12KB to repository Comparison SummarySummary:
|
+1 |
This pull request is fully signed and it will be integrated in one of the next CMSSW_14_1_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_14_2_X is complete. This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @mandrenguyen, @rappoccio, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
backport of #45803
PR description:
This PR is the ECAL equivalent of #43329.
While our final aim is to fully deprecate calotowers, there is no clear ETA for that. Several POGs still use calotowers, specially at HLT. So, to ensure that correct HCAL thresholds are used in making calotowers, the safest way is to use the thresholds from GT.
That is what is done in this PR.
This PR was sparked by the observation that at the HLT we are using the following configuration:
which looks exceedingly low given that 0.3 GeV threshold in EE for all crystals is too small threshold to mitigate the noise in EE.
There are crystals in EE where the threshold is order of 10 GeV (reaching up to ~50 GeV or maybe even higher these days).
Indeed inspecting the last IOV of the
EcalPFRecHitThresholdsRcd
associated tag at HLT,I see rather large thresholds especially in EE:
This PR allows to change the logic of the code to use the
EcalPFRecHitThresholds
from GT instead of the fixed values.The new parameter
EcalRecHitThresh
is set to false, such that this PR is technically a no-op.PR validation:
Validation was purely technical:
runTheMatrix.py - l limited --ibeos
.If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:
This is a verbatim backport of #45803 to the 2024 PRef and HIon data-taking release (CMSSW_14_1_X). TSG is aiming to deploy this + a new version of the HLT JECs for that run.