Refactor edmCheckClassVersion
#45610
Conversation
|
cms-bot internal usage |
|
-code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45610/41104
Code check has found code style and quality issues which could be resolved by applying following patch(s)
|
makortel
force-pushed
the
edmCheckClassVersionRefactor
branch
from
8817f6b
to
0ab1599
Compare
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45610/41105
|
|
A new Pull Request was created by @makortel for master. It involves the following packages:
@Dr15Jones, @cmsbuild, @makortel, @smuzaffar can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
@cmsbuild, please test |
|
|
||
| # Prepend NEW_CMSSW_BASE's lib/src paths in to LD_LIBRARY_PATH and ROOT_INCLUDE_PATH | ||
| export LD_LIBRARY_PATH=${NEW_CMSSW_BASE}/lib/${SCRAM_ARCH}:${LD_LIBRARY_PATH} | ||
| export ROOT_INCLUDE_PATH=${NEW_CMSSW_BASE}/src:${ROOT_INCLUDE_PATH} |
There was a problem hiding this comment.
Up to here this test script mimics https://github.com/cms-sw/cmssw/blob/master/IOPool/Input/test/testNoParentDictionary.sh
I couldn't come up with a simpler setup that would check the behavior of the edmCheckClassVersion when a class is updated (I tried a few but they didn't work).
|
@smuzaffar Could you review? (especially the test part) |
|
-1 Failed Tests: UnitTests Unit TestsI found 1 errors in the following unit tests: ---> test TestFWCoreReflectionCheckClassVersionUpdate had ERRORS Comparison SummarySummary:
|
makortel
force-pushed
the
edmCheckClassVersionRefactor
branch
from
0ab1599
to
81cb174
Compare
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45610/41133
|
|
Pull request #45610 was updated. @Dr15Jones, @cmsbuild, @makortel, @smuzaffar can you please check and sign again. |
| @@ -6,3 +6,4 @@ | |||
|
|
|||
| <test name="TestFWCoreReflectionCheckClassVersion" command="run_checkClassVersion.sh"/> | |||
| <test name="TestFWCoreReflectionDumpClassVersion" command="run_dumpClassVersion.sh"/> | |||
| <test name="TestFWCoreReflectionClassVersionUpdate" command="run_classVersionUpdate.sh"/> | |||
There was a problem hiding this comment.
@smuzaffar Another question on test dependencies. Is it possible for a test to declare a dependence on a library that is defined in the same BuildFile.xml (i.e. FWCoreReflectionTestObjects in this case)?
There was a problem hiding this comment.
@makortel , yes by adding <lib name="FWCoreReflectionTestObjects"/> in the <test .... > ` block
There was a problem hiding this comment.
ah wait, this works for <bin .../> but let me check if it works for <test...../> too
There was a problem hiding this comment.
No, currently <test ..../> does not treat <lib name="SomeLocalLib"/> properly but it can be easily fixed.
|
@cmsbuild, please test |
|
-1 Failed Tests: AddOn AddOn Tests
Comparison SummarySummary:
|
|
@cmsbuild, please test Let's try one more time |
|
+1 Size: This PR adds an extra 12KB to repository Comparison SummarySummary:
|
|
+core |
cmsbuild
added
core-approved
fully-signed
and removed
core-pending
pending-signatures
labels
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @sextonkennedy, @mandrenguyen, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2) |
|
+1 |
PR description:
Before starting to add any further ROOT dictionary definition policy checks in
edmCheckClassVersion, I wanted to refactor the code a little bit (just to move all code into functions). I also added a set of tests to ensure the expected behavior when a class is updated. This test revealed a bug the earlier PR #45423 introduced inedmCheckClassVersion -g(that impactsscram b updateclassversion, IIUC) that prevents the script from running.Resolves cms-sw/framework-team#976
PR validation:
Unit tests run.