-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move pair<LocalVector,LocalVector> and pair<LocalPoint,LocalPoint>
dictionaries to DataFormats/GeometryVector
#45564
Conversation
…ctionaries to DataFormats/GeometryVector
cms-bot internal usage |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45564/41047 |
A new Pull Request was created by @makortel for master. It involves the following packages:
@civanch, @cmsbuild, @mdhildreth, @tvami can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@cmsbuild, please test |
type -changes-dataformats |
+1 Size: This PR adds an extra 20KB to repository
Comparison SummarySummary:
|
+1 |
The comparison differences are related to #39803 |
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @sextonkennedy, @rappoccio, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
DataFormats/GeometryVector
is the right place as it defines theVector3DBase
andPoint3DBase
class templates. Found with #45423 (comment).Resolves cms-sw/framework-team#967
PR validation:
Code compiles, and the to-be-added
edmDumpClassVersion
succeeds to process theclasses_def.xml
files.