Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[14_0_X] Use 13_0_9_HLT and 12_4_21_HLT releases in the 22/23 MC production tests #45534

Merged
merged 1 commit into from
Jul 31, 2024

Conversation

makortel
Copy link
Contributor

PR description:

This PR updates the 22/23 MC production tests added in #44886 to use the 13_0_9_HLT and 12_4_21_HLT releases for the HLT step. Those releases include the backports #44921 and #45000, respectively, that allow those releases to read a ROOT file produced with 14_0_X (or later).

Resolves cms-sw/framework-team#956

PR validation:

Unit tests succeed.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Backport of #45514

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @makortel for CMSSW_14_0_X.

It involves the following packages:

  • Configuration/PyReleaseValidation (upgrade, pdmv)

@AdrianoDee, @cmsbuild, @kskovpen, @miquork, @srimanob, @subirsarkar, @sunilUIET can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @fabiocos, @missirol, @slomeo this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 23, 2024

cms-bot internal usage

@makortel
Copy link
Contributor Author

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

-1

Failed Tests: UnitTests
Size: This PR adds an extra 16KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8dfff0/40545/summary.html
COMMIT: c6c4e75
CMSSW: CMSSW_14_0_X_2024-07-23-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/45534/40545/install.sh to create a dev area with all the needed externals and cmssw changes.

Unit Tests

I found 1 errors in the following unit tests:

---> test test_MC_22_setup had ERRORS

Comparison Summary

Summary:

@cmsbuild
Copy link
Contributor

Pull request #45534 was updated. @AdrianoDee, @cmsbuild, @kskovpen, @miquork, @srimanob, @subirsarkar, @sunilUIET can you please check and sign again.

@makortel
Copy link
Contributor Author

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

+1

Size: This PR adds an extra 16KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8dfff0/40550/summary.html
COMMIT: 4ce1b1d
CMSSW: CMSSW_14_0_X_2024-07-23-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/45534/40550/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

@makortel
Copy link
Contributor Author

Comparison differences are related to #39803

@srimanob
Copy link
Contributor

+Upgrade

@AdrianoDee
Copy link
Contributor

+pdmv
(not to self, fix the HLT step in the tests)

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_14_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_14_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @rappoccio, @antoniovilela, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2)

@antoniovilela
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 90cc17a into cms-sw:CMSSW_14_0_X Jul 31, 2024
9 checks passed
@makortel makortel deleted the updateMCProductionTests_140x branch July 31, 2024 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants