Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid uninitialized data in DD4Hep HGCal geometry parameters #45442

Merged
merged 2 commits into from
Jul 15, 2024

Conversation

Dr15Jones
Copy link
Contributor

PR description:

  • initialized all data members in HGCalParameters as valgrind was complaining about an uninitialized value coming from the construction of the class.
  • added sanity checks on values which we believe were probably associated with the uninitialized value.

This is an attempt to work on the occasional non-reproducibility seen in the phase 2 geometry when using dd4hep.

PR validation:

Code compiles.

valgrind was saying uninitialized values were being used from this
class.
@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 12, 2024

cms-bot internal usage

@Dr15Jones
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @Dr15Jones for master.

It involves the following packages:

  • Geometry/HGCalCommonData (geometry, upgrade)

@Dr15Jones, @bsunanda, @civanch, @makortel, @mdhildreth, @srimanob, @subirsarkar can you please review it and eventually sign? Thanks.
@bsunanda, @fabiocos, @martinamalberti this is something you requested to watch as well.
@antoniovilela, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@srimanob
Copy link
Contributor

Thanks very much @Dr15Jones

@cmsbuild
Copy link
Contributor

+1

Size: This PR adds an extra 40KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-274aed/40365/summary.html
COMMIT: 933254a
CMSSW: CMSSW_14_1_X_2024-07-11-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/45442/40365/install.sh to create a dev area with all the needed externals and cmssw changes.

  • DAS Queries: The DAS query tests failed, see the summary page for details.

Comparison Summary

There are some workflows for which there are errors in the baseline:
29634.911 step 2
The results for the comparisons for these workflows could be incomplete
This means most likely that the IB is having errors in the relvals.The error does NOT come from this pull request

Summary:

  • You potentially removed 15 lines from the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 6 differences found in the comparisons
  • DQMHistoTests: Total files compared: 47
  • DQMHistoTests: Total histograms compared: 3246798
  • DQMHistoTests: Total failures: 6
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3246772
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 46 files compared)
  • Checked 199 log files, 163 edm output root files, 47 DQM output files
  • TriggerResults: no differences found

@civanch
Copy link
Contributor

civanch commented Jul 13, 2024

+1

@srimanob
Copy link
Contributor

+Upgrade

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @sextonkennedy, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

@srimanob
Copy link
Contributor

Testing with 200 jobs (200 events each), all jobs run fine. No issue of #41927 and #41451 have been observed.

@bsunanda
Copy link
Contributor

@Dr15Jones Thanks Chris. I should have looked into this

@bsunanda
Copy link
Contributor

@antoniovilela, @rappoccio Please integrate it urgently

@rappoccio
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 0222be8 into cms-sw:master Jul 15, 2024
11 checks passed
@Dr15Jones Dr15Jones deleted the dd4HepHGCal branch July 17, 2024 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants