Include HIon type traits for Alpaka pixel tracking

[vince502]

PR description:

This is a PR to re-include templates for HIon pixel tracking. We expect no dependency from this change, and will be only used to modify HLT trigger menus. The parameters for the classes are identical to 2023 configuration, updates on them will follow after this PR when we have tracking studies ready.

PR validation:

HLT re-emulation was tested with the modified HIon trigger menu in CMSSW_14_1_0_pre2 and CMSSW_14_1_0_pre3. The RAW sample generated from runTheMatrix.py -w upgrade -l 15550.402 was used for test. No problem was found in CMSSW_14_1_0_pre3.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

I don't think backport is needed and can be only for releases moving forward.

Best,
Soohwan

[cmsbuild]

cms-bot internal usage

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45151/40493

• This PR adds an extra 40KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File RecoTracker/PixelSeeding/plugins/alpaka/CAHitNtuplet.cc modified in PR(s): Alpaka vs CUDA DQM compare modules for pixel tracks objects #43964

[cmsbuild]

A new Pull Request was created by @vince502 for master.

It involves the following packages:

• DataFormats/TrackSoA (heterogeneous, reconstruction)
• RecoLocalTracker/SiPixelRecHits (reconstruction)
• RecoTracker/PixelSeeding (reconstruction)

@jfernan2, @mandrenguyen, @cmsbuild, @fwyzard, @makortel can you please review it and eventually sign? Thanks.
@tsusa, @ferencek, @rovere, @VinInn, @JanFSchulte, @tvami, @threus, @dgulhan, @mmusich, @gpetruc, @mtosi, @VourMa, @GiacomoSguazzoni, @mroguljic, @missirol, @felicepantaleo, @dkotlins this is something you requested to watch as well.
@antoniovilela, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

[missirol]

@vince502

I don't think backport is needed and can be only for releases moving forward.

I would think a backport of this PR to 14_0_X is useful (and, afaiu, has no downside), so that we can start integrating HIon updates in 14_0_X menus, without having to wait until the HLT menus are moved to 14_1_X months from now. @cms-sw/hlt-l2

[fwyzard]

please test

[fwyzard]

@vince502 is there a matrix workflow that exercises these template specialisations?

Something similar to 12434.402, 12434.403, and 12434.404, but using a heavy ions MC sample and reconstruction ?

[vince502]

@fwyzard can we used the mentioned 15550.402 suggested by @AdrianoDee, which use the PbPb MC with HI pixel only reconstruction?

[fwyzard]

Yes, you can use 15550.402, but it needs to run the HI version of the reconstruction.

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-78ba6a/39741/summary.html
COMMIT: 2fa7212
CMSSW: CMSSW_14_1_X_2024-06-05-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/45151/39741/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially added 1 lines to the logs
• Reco comparison results: 5 differences found in the comparisons
• DQMHistoTests: Total files compared: 49
• DQMHistoTests: Total histograms compared: 3445482
• DQMHistoTests: Total failures: 9
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3445453
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
• Checked 206 log files, 170 edm output root files, 49 DQM output files
• TriggerResults: no differences found

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45151/40526

• This PR adds an extra 28KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File RecoLocalTracker/SiPixelClusterizer/python/siPixelClustersPreSplitting_cff.py modified in PR(s): Alpaka vs CUDA DQM compare modules for pixel tracks objects #43964
  • File RecoLocalTracker/SiPixelRecHits/python/SiPixelRecHits_cfi.py modified in PR(s): New Heterogeneous Memory Pool #37952, Alpaka vs CUDA DQM compare modules for pixel tracks objects #43964
  • File RecoTracker/Configuration/python/RecoPixelVertexing_cff.py modified in PR(s): Alpaka vs CUDA DQM compare modules for pixel tracks objects #43964
  • File RecoTracker/PixelSeeding/plugins/alpaka/CAHitNtuplet.cc modified in PR(s): Alpaka vs CUDA DQM compare modules for pixel tracks objects #43964
  • File RecoTracker/PixelTrackFitting/python/PixelTracks_cff.py modified in PR(s): Alpaka vs CUDA DQM compare modules for pixel tracks objects #43964

[fwyzard]

-heterogeneous

Waiting to fix the commits after the rebase

[vince502]

I've merged the commits into one. It should have the same difference as before rebasing.

[mandrenguyen]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-78ba6a/40053/summary.html
COMMIT: c5df667
CMSSW: CMSSW_14_1_X_2024-06-24-1100/el8_amd64_gcc12
Additional Tests: GPU
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/45151/40053/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

There are some workflows for which there are errors in the baseline:
15550.402 step 3
The results for the comparisons for these workflows could be incomplete
This means most likely that the IB is having errors in the relvals.The error does NOT come from this pull request

Summary:

• You potentially removed 57 lines from the logs
• ROOTFileChecks: Some differences in event products or their sizes found
• Reco comparison results: 17 differences found in the comparisons
• DQMHistoTests: Total files compared: 49
• DQMHistoTests: Total histograms compared: 3451610
• DQMHistoTests: Total failures: 850
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3450740
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
• Checked 209 log files, 175 edm output root files, 49 DQM output files
• TriggerResults: no differences found

GPU Comparison Summary

There are some workflows for which there are errors in the baseline:
15550.402 step 3
The results for the comparisons for these workflows could be incomplete
This means most likely that the IB is having errors in the relvals.The error does NOT come from this pull request

Summary:

• You potentially removed 87 lines from the logs
• ROOTFileChecks: Some differences in event products or their sizes found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 3
• DQMHistoTests: Total histograms compared: 39744
• DQMHistoTests: Total failures: 20
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 39724
• DQMHistoTests: Total skipped: 0
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 2 files compared)
• Checked 11 log files, 15 edm output root files, 3 DQM output files
• TriggerResults: no differences found

[mandrenguyen]

+1

[fwyzard]

+heterogeneous

Thanks for squashing the commits!

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @rappoccio, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

[mmusich]

@vince502 please prepare a backport to CMSSW_14_0_X as requested at #45151 (comment).

[rappoccio]

+1