-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Include HIon type traits for Alpaka pixel tracking #45151
Conversation
cms-bot internal usage |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45151/40493
|
A new Pull Request was created by @vince502 for master. It involves the following packages:
@jfernan2, @mandrenguyen, @cmsbuild, @fwyzard, @makortel can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
I would think a backport of this PR to 14_0_X is useful (and, afaiu, has no downside), so that we can start integrating HIon updates in 14_0_X menus, without having to wait until the HLT menus are moved to 14_1_X months from now. @cms-sw/hlt-l2 |
please test |
@vince502 is there a matrix workflow that exercises these template specialisations? Something similar to 12434.402, 12434.403, and 12434.404, but using a heavy ions MC sample and reconstruction ? |
@fwyzard can we used the mentioned 15550.402 suggested by @AdrianoDee, which use the PbPb MC with HI pixel only reconstruction? |
Yes, you can use |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-78ba6a/39741/summary.html Comparison SummarySummary:
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45151/40526
|
-heterogeneous Waiting to fix the commits after the rebase |
ff12167
to
c5df667
Compare
I've merged the commits into one. It should have the same difference as before rebasing. |
please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-78ba6a/40053/summary.html Comparison SummaryThere are some workflows for which there are errors in the baseline: Summary:
GPU Comparison SummaryThere are some workflows for which there are errors in the baseline: Summary:
|
+1 |
+heterogeneous Thanks for squashing the commits! |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @rappoccio, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2) |
@vince502 please prepare a backport to CMSSW_14_0_X as requested at #45151 (comment). |
+1 |
[14_0] Backport of #45151 (HIon type def for pixel alpaka)
PR description:
This is a PR to re-include templates for HIon pixel tracking. We expect no dependency from this change, and will be only used to modify HLT trigger menus. The parameters for the classes are identical to 2023 configuration, updates on them will follow after this PR when we have tracking studies ready.
PR validation:
HLT re-emulation was tested with the modified HIon trigger menu in CMSSW_14_1_0_pre2 and CMSSW_14_1_0_pre3. The RAW sample generated from
runTheMatrix.py -w upgrade -l 15550.402
was used for test. No problem was found in CMSSW_14_1_0_pre3.If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:
I don't think backport is needed and can be only for releases moving forward.
Best,
Soohwan